[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ioreq: don't wrongly claim "success" in ioreq_send_buffered()

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Julien Grall <julien@xxxxxxx>
Date: Mon, 7 Oct 2024 22:08:52 +0100
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Mon, 07 Oct 2024 21:08:56 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Jan,

On 30/09/2024 11:28, Jan Beulich wrote:

Returning a literal number is a bad idea anyway when all other returns
use IOREQ_STATUS_* values. The function is dead on Arm, and mapping to
X86EMUL_OKAY is surely wrong on x86.

Fixes: f6bf39f84f82 ("x86/hvm: add support for broadcast of buffered ioreqs...")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall

Prev by Date: Re: [PATCH v5 16/44] x86/boot: introduce consumed flag for struct boot_module
Next by Date: [PATCH v1 0/1] hw/xen: Avoid Avoid use of uninitialized bufioreq_evtchn
Previous by thread: [linux-linus test] 187997: tolerable FAIL - PUSHED
Next by thread: [PATCH v1 0/1] hw/xen: Avoid Avoid use of uninitialized bufioreq_evtchn
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.