Re: [PATCH v2 00/19] Update header guards bases on new coding style

[Frediano Ziglio <frediano.ziglio@xxxxxxxxx>]

On Fri, Oct 4, 2024 at 7:23 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 03.10.2024 19:59, Frediano Ziglio wrote:
> > With the help of some scripts and manual checking I updated header guards.
> >
> > As the changes are pretty large patch was split based on maintainers
> > to reduce mail spamming.
> >
> > Excluded public headers from the update, they are API, software like
> > Qemu will fail to compile if changed.
>
> Interesting - the first patch I peeked at, ...
>
> > Changes since v1:
> > - make all commit compile;
> > - exclude public headers, their guard is not an API.
> >
> > Frediano Ziglio (19):
> >   xen: Update header guards - Generic
> >   xen: Update header guards - X86
> >   xen: Update header guards - ACPI
> >   xen: Update header guards - ARGO
>
> ... this one, adjusts a public header. And the diffstat ...
>
> >  xen/include/public/arch-arm.h                           | 6 +++---
> >  xen/include/public/arch-arm/hvm/save.h                  | 4 ++--
> >  xen/include/public/arch-arm/smccc.h                     | 6 +++---
> >  xen/include/public/arch-x86/cpufeatureset.h             | 6 +++---
> >  xen/include/public/arch-x86/cpuid.h                     | 6 +++---
> >  xen/include/public/arch-x86/guest-acpi.h                | 6 +++---
> >  xen/include/public/arch-x86/hvm/save.h                  | 6 +++---
> >  xen/include/public/arch-x86/hvm/start_info.h            | 6 +++---
> >  xen/include/public/arch-x86/pmu.h                       | 6 +++---
> >  xen/include/public/arch-x86/xen-mca.h                   | 6 +++---
> >  xen/include/public/arch-x86/xen-x86_32.h                | 6 +++---
> >  xen/include/public/arch-x86/xen-x86_64.h                | 6 +++---
> >  xen/include/public/arch-x86/xen.h                       | 6 +++---
> >  xen/include/public/argo.h                               | 4 ++--
> >  xen/include/public/vm_event.h                           | 6 +++---
>
> ... also contradicts that statement. Please clarify.
>
> Jan

Hi,
   I just missed these. Excluding, better to be safe for the first
round, we can consider guards in the public headers later.

Frediano