Re: [PATCH v5 1/6] xen: introduce DECL_SECTION_WITH_LADDR

[oleksii.kurochko@xxxxxxxxx]

On Mon, 2024-09-30 at 09:20 +0200, Jan Beulich wrote:
> On 27.09.2024 18:32, Oleksii Kurochko wrote:
> > --- a/xen/arch/x86/xen.lds.S
> > +++ b/xen/arch/x86/xen.lds.S
> > @@ -3,6 +3,10 @@
> >  
> >  #include <xen/cache.h>
> >  #include <xen/lib.h>
> > +
> > +#ifndef EFI
> > +# define DECL_SECTION_WITH_LADDR
> > +#endif
> 
> I think either this wants inserting at the very top or it wants
> moving down
> together with ...
> 
> >  #include <xen/xen.lds.h>
> 
> ... this line, past all the #includes (and, much you have it,
> separated by a
> blank line, just at both sides). Can adjust while committing of
> course.

Personally, I prefer to move that down. It would be great if you could
do that during committing.

Thanks a lot.

~ Oleksii