[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] changelog: add note about blkif protocol fixes



On Wed, Sep 25, 2024 at 12:18:59PM +0100, Andrew Cooper wrote:
> On 12/09/2024 2:23 pm, Roger Pau Monne wrote:
> > Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> >  CHANGELOG.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/CHANGELOG.md b/CHANGELOG.md
> > index 26e7d8dd2ac4..8864ea7eafad 100644
> > --- a/CHANGELOG.md
> > +++ b/CHANGELOG.md
> > @@ -9,6 +9,7 @@ The format is based on [Keep a 
> > Changelog](https://keepachangelog.com/en/1.0.0/)
> >  ### Changed
> >   - On x86:
> >     - Prefer ACPI reboot over UEFI ResetSystem() run time service call.
> > + - Fixed blkif protocol specification for sector sizes different than 512b.
> 
> It's minor, but blkif is common, so should go ahead of the "On x86"
> subsection.

Oh, it's in common (indentation wise) it's just after the x86 section.
For other release notes we have the x86/ARM/... sections first, and
afterwards the common changes.

I don't mind putting the common changes first and the arch-specific
ones later, but it should likely be documented somewhere.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.