Re: [PATCH v2] x86/efi: Use generic PE/COFF structures

[Milan Đokić <milandjokic1995@xxxxxxxxx>]

>
> Not strong about, a change like
>
> $ git diff
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index 286c003ec3..00ab091634 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -88,6 +88,8 @@ extra-y += xen.lds
> hostprogs-y += boot/mkelf32
> hostprogs-y += efi/mkreloc
>
> +$(obj)/efi/mkreloc: HOSTCFLAGS += -I$(srctree)/include
> +
> # Allows usercopy.c to include itself
> $(obj)/usercopy.o: CFLAGS-y += -iquote .
>
> diff --git a/xen/arch/x86/efi/mkreloc.c b/xen/arch/x86/efi/mkreloc.c
> index 89c525d81e..7c9aac49ed 100644
> --- a/xen/arch/x86/efi/mkreloc.c
> +++ b/xen/arch/x86/efi/mkreloc.c
> @@ -9,7 +9,7 @@
> #include <sys/mman.h>
> #include <unistd.h>
>
> -#include "../../../include/efi/pe.h"
> +#include <efi/pe.h>
>
> #define PE_PAGE_SIZE 0x1000
>
>
> would work. Not sure the best place to put the option in the Makefile
> or I should change a different macro.
>
Much better solution than ours. We'll try out your suggestion and send
an updated patch. Thanks.

BR,
Milan