[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] x86/boot: Drop stale comment about zeroing the stack
On Mon, Sep 16, 2024 at 12:58 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: > > This used to be true, but was altered by commit 37786b23b027 ("x86/cet: Remove > writeable mapping of the BSPs shadow stack") which moved cpu0_stack into > .init.bss.stack_aligned. > > Fixes: 37786b23b027 ("x86/cet: Remove writeable mapping of the BSPs shadow > stack") > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > --- > CC: Jan Beulich <JBeulich@xxxxxxxx> > CC: Roger Pau Monné <roger.pau@xxxxxxxxxx> > CC: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> > --- > xen/arch/x86/boot/head.S | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 12bbb97f33d4..cfc5a7b47d29 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -652,11 +652,7 @@ trampoline_setup: > cmpb $0, sym_esi(efi_platform) > jnz 1f > > - /* > - * Initialise the BSS. > - * > - * !!! WARNING - also zeroes the current stack !!! > - */ > + /* Initialise the BSS. */ > lea sym_esi(__bss_start), %edi > lea sym_esi(__bss_end), %ecx > sub %edi,%ecx > > base-commit: a8bf14f6f331d4f428010b4277b67c33f561ed19 Nice to know! Acked-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx> Frediano
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |