Re: [PATCH v1 3/3] xen/common: move device initialization code to common code

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.09.2024 16:35, oleksii.kurochko@xxxxxxxxx wrote:
> On Thu, 2024-09-12 at 17:28 +0200, Jan Beulich wrote:
>> On 11.09.2024 12:04, Oleksii Kurochko wrote:
>>> --- a/xen/common/Makefile
>>> +++ b/xen/common/Makefile
>>> @@ -6,6 +6,7 @@ obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
>>>  obj-$(CONFIG_CORE_PARKING) += core_parking.o
>>>  obj-y += cpu.o
>>>  obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o
>>> +obj-$(call or,$(CONFIG_HAS_DEVICE_TREE),$(CONFIG_HAS_ACPI)) +=
>>> device.o
>>
>> I can't spot any HAS_ACPI in the tree. And if this was switched to
>> CONFIG_ACPI
>> I'd further ask why the file needs building on x86.
> Oh, there is no need for building this on x86. With what you suggested
> here ...
> 
>>
>> Also I think I'd prefer to avoid the of the "or" macro here:
>>
>> obj-$(CONFIG_ACPI) += device.o
>> obj-$(CONFIG_HAS_DEVICE_TREE) += device.o
> ... IIUC it will fix the issue with building this file for x86 as
> CONFIG_ACPI depends on (ARM_64 && ARM_EFI).

Except that "depends on" is itself Arm-only, so won't affect x86.
Or else x86 would end up without ACPI support, which would mean
full breakage on about every system.

Jan