Re: [PATCH] x86/mm: undo type change of partial_flags

[Frediano Ziglio <frediano.ziglio@xxxxxxxxx>]

On Thu, Sep 12, 2024 at 4:38 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> Clang dislikes the boolean type combined with the field being set using
> PTF_partial_set.
>
> Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/include/asm/mm.h
> +++ b/xen/arch/x86/include/asm/mm.h
> @@ -286,7 +286,7 @@ struct page_info
>          struct {
>              u16 nr_validated_ptes:PAGETABLE_ORDER + 1;
>              u16 :16 - PAGETABLE_ORDER - 1 - 1;
> -            bool partial_flags:1;
> +            uint16_t partial_flags:1;
>              int16_t linear_pt_count;
>          };
>
>
I knew MS compiler does not like too, but I only tested with GCC, and
it was fine with it

Reviewed-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>

Frediano