Re: [PATCH] tools/ocaml/xc: Drop the GC lock for all hypercalls

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 2 Sep 2024, at 17:13, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
> 
> On 02/09/2024 9:12 am, Christian Lindig wrote:
>>> On 30 Aug 2024, at 18:53, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>> 
>>> We should be doing this unilaterally.
>> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>
> 
> Thanks.
> 
>> 
>> I would prefer to use caml_release_runtime_system(), 
>> caml_acquire_runtime_system() which I think is a better name for these 
>> functions. This could be likewise changed globally.
>> 
>> https://ocaml.org/manual/5.2/intfc.html#ss:parallel-execution-long-running-c-code
> 
> This is a mess.
> 
> Despite existing for 14 years, Ocaml (threads.h) still does this:
> 
> CAMLextern void caml_enter_blocking_section (void);
> CAMLextern void caml_leave_blocking_section (void);
> #define caml_acquire_runtime_system caml_leave_blocking_section
> #define caml_release_runtime_system caml_enter_blocking_section
> 
> So the "new" names are implemented in terms of the "old" ones, not the
> other way around.
> 
> Do you mind if we defer the rename until a later point?  For better or
> worse, Xen uses the old names consistently.

That’s fine.

— C