[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 5/5] x86/amd: optional build of amd.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Thu, 29 Aug 2024 12:48:19 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mgER5DsOgs79K3ivRSOoBr4SXrbT3Cq0I8G6lG1sDmA=; b=I3akgr6BYw7SojFgEtn47Z4J7RhJtqDkeqfoklULN9M/Dy2e1R3VpT0VJ2/h6OTr34EphQcQ8X0yzz/23mGrEhE8wu+NWmHhmyI6+ASM/EUchWvtYGmrKBvpX2GCk6Qyd6Rzvdaw4Kmh59LWEKdtSAVDcaGW1gtuNTmTyfTUWZTmdJVOJCkq1otbJZqzObrkEj3LHTkgPDn11Lyc1oDBRJ/UbwdJT8RVkKZhmwAcjm8WErH2VybLGUpP6XL5Vvp7SPlxNDi4lTc2BbEnDbY6QAOFsZCSUjWLldgYf1zAag2YZJm7XotHbVkLvq3lmaw0v29ttDmorJB9AFmPwbqTrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IUDSnMHxUO2KJBhnhOzhDIgTtiSVl7fJ3JKvzV+2/rX2fqFJAmjnrhrn4SrijW7HiqzETzODIlejN+Ihowfb2f896ISQU1vX44sDcLOB3CyuRr9QEFvrNrqFlBUKPAMLJXGarop2keIhbscJlNTGX9gKlBeur4JF/uqcmWGtAHLQm5w9OHgp0NDHZ5avoZv6z+cO4SLcNB1gSZjh5Of6DkX2P1WAuRTbzLe5YYYETc+yOND6b3lhmJ8wMsegtO2QUtALocnG1EJxDFlXKazclC+C5Ks500eQoNGEsSnpPVkjKI+Xm1WhEnTy0eeAkm8wF/vHSsYU7mhqyobVYZxelQ==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 29 Aug 2024 09:48:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
19.08.24 15:36, Jan Beulich:
On 16.08.2024 13:19, Sergiy Kibrik wrote:
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -919,7 +919,8 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
* Possibly clear previous guest selection of SSBD if set. Note that
* SPEC_CTRL.SSBD is already handled by svm_vmexit_spec_ctrl.
*/
- if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+ if ( IS_ENABLED(CONFIG_AMD) &&
+ v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
{
ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
amd_set_legacy_ssbd(false);
@@ -953,7 +954,8 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
/* Load SSBD if set by the guest. */
- if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+ if ( IS_ENABLED(CONFIG_AMD) &&
+ v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
{
ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
amd_set_legacy_ssbd(true);
Instead of these changes, shouldn't AMD_SVM become dependent upon AMD in
Kconfig?
It could be done earlier, yet I haven't done so since we briefly touched
this before and decided not to link {AMD,INTEL} with {AMD_SVM,INTEL_VMX}
then:
https://lore.kernel.org/xen-devel/9a973f18-e0af-456c-8b07-6869f044519e@xxxxxxxxxx/
-Sergiy
|
