[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] automation: fix false success in qemu tests
- To: <victorm.lira@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 29 Aug 2024 08:53:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFs28kpno5mKFR628jWVGAfUyjLnvihFrGHeClS/aE8=; b=zDlfEMPZESqD2ovP1+rkBpBnkVyAEliEDoRi5rESIAIfcz/hxTudRj0d1vdj2mq2f4eE4S4EW4JLKQVsIe3E4xd7oeRGLt9xrH0ntWr+psZoeaZmYMUm9AHAQBzSY6Nq4LmAh9nezk5JJm9cQ85JxOyYJXw4jOcuGrhpMJoryh3OTS+KqBsrCczXwIQz8nWuNGVqO4EMD1T2JjyI3yJnnC51b4ctsFGkM/l133AQMdctQjs5l/JajIMlQwqMRHwaXRWWsavBTiwweBipxGfc9D2kbR5p5z4uAYany5On+pctksX3lE3M8Q8vhbP25wxAmSzjG5v2ytOavXAmEy9LTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fByj/DAnc8QRs3tEDZJmangC+DzdD6+n9MuHibhoNPGTrmohWZtZXXK/5MQa7Vafbm6ERMEWq+b0KfBqJgkm7L/4zTiJrVYn6yrhESb2m4L8xPpDBd+tj35oE+LMW9t6qunf+qZA5BsOfZ2vhY8KnSJXgCYrIoKRdl9BKB0dD0C/qPTwjK3jU/CmcpU0urDnGCo1F7UueeaHO3scB2YIg9YCBTndgk9+60JOr/GDIeZtTBycyK6h75afimLWbnt8AIslRv2hlopRZn5e/5pkNRjie0xbA9LDx1txva+3cbgWPpoVG/BiTN9+DXNOzb2NttXe820RmAjZs0woeS4dMA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 29 Aug 2024 06:53:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Victor,
On 29/08/2024 06:09, victorm.lira@xxxxxxx wrote:
>
>
> From: Victor Lira <victorm.lira@xxxxxxx>
>
> Fix flaw in qemu-*.sh tests that producess a false success. The following
> lines produces success despite the "expect" script producing nonzero exit
> status.
>
> set +e
> ...
> ./automation/scripts/qemu-key.exp | sed 's/\r\+$//'
> (end of file)
>
> The "set +e" is sometimes needed for cleanup such as powering off hardware
> after running a test.
>
> Fixes the CI failure introduced by 95764a0817.
You may want to use "Fixes" tag. See docs/process/sending-patches.pandoc.
>
> Update xilinx-smoke tests to use the "expect" utility for early exit from
> tests. Generalize the variable names in the script "qemu-key.exp" to be
> used by both QEMU and hardware tests. Add a missing "-continue_timer" flag
> for the expect script to properly time out. Add "expect" to xilinx
> dockerfile.
This commit tries to do 2 thins at once:
- fix "set +e" issue
- make xilinx tests use expect
These should be 2 separate patches. The first patch should only remove "set +e"
from qemu patches.
There is no need for fifo in qemu tests. You should use that only in xilinx
tests where we cannot remove "set +e".
~Michal
|
