Re: [XEN PATCH 1/3] libxl: Implement QEMU command line probe

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Aug 27, 2024 at 06:17:05PM -0400, Jason Andryuk wrote:
> On 2024-08-27 06:03, Anthony PERARD wrote:
> > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > 
> > Starting with QEMU 9.0, the option "-chroot", that we use for the
> > "dmrestrict" feature, is removed. We need to find out which to use
> > between "-chroot" and "-run-with chroot=dir".
> > 
> > This patch implement the machinery to spawn QEMU, and to run the QMP
> > command "query-command-line-options" but doesn't yet look at the
> > actual result. Whether or not to use "-run-with chroot=dir" will be
> > implemented in a follow up patch.
> > 
> > The command line used to spawn the qemu we want to probe is mostly
> > similar to the one we already use for the device model, "-machine
> > none" comes from libvirt.
> > 
> > This patch implement the probing on qemu-xen, even if we probably not
> > going to use the result. We could check the feature wanted for the
> > domain been created, but this could get complicated fairly quickly.
> 
> "domain being created"?

Yes.

> > We already need to check the options "b_info->dm_restrict" for
> > "-chroot" and "state->dm_runas" for "-runas" (which is deprecated).
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech