[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] dma-mapping: clear mark DMA ops as an architecture feature



On 24/08/2024 4:57 am, Christoph Hellwig wrote:
DMA ops are a helper for architectures and not for drivers to override
the DMA implementation.  Unfortunately driver authors keep ignoring
this.  Make this more clear by renaming the symbol to ARCH_DMA_OPS,
have the three drivers overriding it depend on that.  They should
probably also be marked broken, but we can give them a bit of a grace
period for that.

Nit: from a quick survey of "git grep 'select ARCH_'", maybe ARCH_HAS_DMA_OPS might be the clearest and most consistent name? Otherwise, now that any potential confusion from drivers/iommu is no more, I too thoroughly approve of the overall idea.

Acked-by: Robin Murphy <robin.murphy@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.