Re: [PATCH v7 2/3] x86/ucode: Introduce --force option to xen-ucode

[Fouad Hilly <fouad.hilly@xxxxxxxxx>]

On Fri, Aug 23, 2024 at 7:48 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:

On 22.08.2024 15:04, Fouad Hilly wrote:
> @@ -79,7 +81,10 @@ static void usage(FILE *stream, const char *name)
>              "Usage: %s [options | microcode-file]\n"
>              "options:\n"
>              "  -h, --help               display this help\n"
> -            "  -s, --show-cpu-info      show CPU information\n",
> +            "  -s, --show-cpu-info      show CPU information\n"
> +            "  -f, --force              skip certain checks when applying\n"
> +            "                           microcode; do not use unless you know\n"
> +            "                           exactly what you are doing\n",
>              name, name);

As indicated before: --force does no longer fit "[options | microcode-file]".
The form coming closest is imo going to be "[options] [microcode-file]", with
the file name simply taking no effect when specified together with one of the
pre-existing two options.

My bad, I missed this change in v7.

I agree,  "[options] [microcode-file]" seems to better fit with the introduction of --force.

If there are no further comments on the rest of the patch series, I can prep v8 with this change.

Jan

Thanks,

Fouad