[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/arm: Drop {boot_}phys_offset usage



Hi Michal,

On 14/08/2024 10:43, Michal Orzel wrote:
boot_phys_offset stores the physical offset (PA-VA), is calculated in
the startup head.S code and passed to start_xen() as a first argument.
There is no point in using it given that we can ask MMU to translate
a VA for us using e.g. virt_to_{mfn,maddr}. Drop usage of these
variables from the C world.

I think the code is a remanant of when Xen would be relocated to the top of the RAM. In this case, virt_to_mfn() would not have worked.

This was removed by f60658c6ae47 ("xen/arm: Stop relocating Xen") and I don't expect the relocation code to be re-introduced. So...


Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

...

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.