Re: [XEN PATCH v1 1/2] x86/intel: optional build of intel.c

[Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>]

09.08.24 13:36, Alejandro Vallejo:
> On Fri Aug 9, 2024 at 11:09 AM BST, Sergiy Kibrik wrote:
> > With specific config option INTEL in place and most of the code that depends
> > on intel.c now can be optionally enabled/disabled it's now possible to put
> > the whole intel.c under INTEL option as well. This will allow for a Xen build
> > without Intel CPU support.
> >
> > Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
> > ---
> >   xen/arch/x86/cpu/Makefile            | 6 +++---
> >   xen/arch/x86/cpu/common.c            | 4 +++-
> >   xen/arch/x86/include/asm/processor.h | 7 ++++---
> >   3 files changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/xen/arch/x86/cpu/Makefile b/xen/arch/x86/cpu/Makefile
> > index eafce5f204..020c86bda3 100644
> > --- a/xen/arch/x86/cpu/Makefile
> > +++ b/xen/arch/x86/cpu/Makefile
> > @@ -6,10 +6,10 @@ obj-y += amd.o
> >   obj-y += centaur.o
> >   obj-y += common.o
> >   obj-y += hygon.o
> > -obj-y += intel.o
> > -obj-y += intel_cacheinfo.o
> > +obj-$(CONFIG_INTEL) += intel.o
> > +obj-$(CONFIG_INTEL) += intel_cacheinfo.o
> >   obj-y += mwait-idle.o
> > -obj-y += shanghai.o
> > +obj-$(CONFIG_INTEL) += shanghai.o
> Why pick this one too? It's based on VIA IP, aiui.
shanghai.c and intel.c both use init_intel_cacheinfo() routine, so 
there's build dependency on Intel code.
  -Sergiy