Re: [PATCH] libxl/disk: avoid aliasing of abs()

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 5 Aug 2024, Jan Beulich wrote:
> Tool chains with -Wshadow enabled by default won't like the function
> parameter name "abs", for aliasing stdlib.h's abs(). Rename the
> parameter to what other similar functions use.
> 
> Fixes: a18b50614d97 ("libxl: Enable stubdom cdrom changing")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> --- a/tools/libs/light/libxl_disk.c
> +++ b/tools/libs/light/libxl_disk.c
> @@ -935,7 +935,7 @@ static void cdrom_insert_stubdom_disk_ad
>                                               libxl__ao_device *aodev);
>  static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
>                                               libxl__ev_time *ev,
> -                                             const struct timeval *abs,
> +                                             const struct timeval 
> *requested_abs,
>                                               int rc);
>  static void cdrom_insert_stubdom_parse_fdset(libxl__egc *egc,
>                                               libxl__ev_qmp *qmp,
> @@ -1259,7 +1259,7 @@ static void cdrom_insert_stubdom_disk_ad
>  
>  static void cdrom_insert_stubdom_query_fdset(libxl__egc *egc,
>                                               libxl__ev_time *ev,
> -                                             const struct timeval *abs,
> +                                             const struct timeval 
> *requested_abs,
>                                               int rc)
>  {
>      EGC_GC;
>