[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 2/4] xen: arm: make VMAP only support in MMU system


  • To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, sstabellini@xxxxxxxxxx, bertrand.marquis@xxxxxxx, michal.orzel@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Mon, 5 Aug 2024 11:44:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hco20DxapGbz/qeh7BEKD6UNZGS9ISlQ2qWzNelTuf8=; b=TuM7KVGnPtc1qn6LosP09zYB6f5JoGieAf27XpYfSdMFnNF9JVYlJYmmC4azPpXg533RsA34mtr2kHViFCCnbrB6bbsAoEuAikNAqcrdHVy2vnbgA3n70yUMNC3Jw/9V5WJbhkfRRTxl361fvMoUYY3ExJmM3NQXrczE6z4ZiiWDPInq66oT7DhrbJkgbv2N31wgGmtqsRu4YroUgokkuzH74gmNZZKNVRev296v7TPOIqUW4ySFqtmDl3SjC/uNalVcMPVe6UYaBDpijpVHeFu9a7kU8ccTuCVw87pveFF/XvxXvU0xNtrWHVTBPHBnaJqUFCYBBA+8S8amDiOGQA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bv1OM4tzCsB6lBj5rCNxg1F2c0cFHFzHlbH9Wxof7pe3AeSr0WWDyNXbhgQqSxQmjEMQ2S/Z+pxElZzHcvSoPi/snjJmyjOvFrEAGtaMrde3OPBLvEdz6krKShbRqIC39J+CRcDxEGP3FbKZ+MlZD0pphuMUotobwCE9e1603fogz/C9bB0lorjviAvYuTrbI8Mpdf38LKFRY8CNiEeKo/0K1Jl2OCmV3ggtTJGaprbuTXZBSu/p5oSDm/EXVSjtoV4gZEL1WisCiFf+X13+OK5fuuxxzO3WBG3fEOnMSXdMCCg0hhVpyJVogEczRP61iZD/Nqe8F/x3e73gNEsKlQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Penny Zheng <penny.zheng@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
  • Delivery-date: Mon, 05 Aug 2024 10:44:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 02/08/2024 14:27, Julien Grall wrote:
Hi,
Hi Julien,

On 02/08/2024 13:14, Ayan Kumar Halder wrote:
From: Penny Zheng <penny.zheng@xxxxxxx>

VMAP is widely used in ALTERNATIVE feature, CPUERRATA feature, etc to
remap a range of memory with new memory attributes. Since this is
highly dependent on virtual address translation, we choose to fold VMAP
in MMU system.

In this patch, we introduce a new Kconfig CONFIG_HAS_VMAP, and make it
only support in MMU system on ARM architecture. And we make features
like ALTERNATIVE, CPUERRATA, etc, now depend on VMAP.

While I agree that alternative should depend on VMAP (for now), I feel this is incorrect for CPUERRATA. Very likely, you will need to deal with them on the MPU.

Before making any suggestion, would you be able to clarify how you envision to deal with errata? Will they be selected at built time or boot time?

TBH, I hadn't thought that through. I am thinking about selecting them at built time (like it is been done for Arm64 cpus).

However given that there are lesser number of MPU cpus (only R52 and R82) compared to  MMU ones, could there be a simpler approach.

I am open to any suggestions you have.

Also, can we disable the CPUERRATA on MPU until we add support for the first errata ?

- Ayan


Cheers,




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.