Re: [PATCH v7 1/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

[oleksii.kurochko@xxxxxxxxx]

Hi Julien,

On Mon, 2024-08-05 at 10:08 +0100, Julien Grall wrote:
> Hi,
> 
> On 24/07/2024 16:31, Oleksii Kurochko wrote:
> > Changes in V5:
> >   - add xen/include/xen/bootfdt.h to MAINTAINERS file.
> >   - drop message "Early device tree parsing and".
> >   - After rebase on top of the current staging the following
> > changes were done:
> >     - init bootinfo variable in <common/device-tree/bootinfo.c>
> > with BOOTINFO_INIT;
> >     - update the code of dt_unreserved_regions():
> >         CONFIG_STATIC_SHM related changes and getting of
> > reserved_mem
> >         bootinfo_get_shmem() ??
> >     - update the code of meminfo_overlap_check():
> >         add check ( INVALID_PADDR == bank_start ) to if case.
> >     - update the code of check_reserved_regions_overlap():
> >         CONFIG_STATIC_SHM related changes.
> >     - struct bootinfo was updated ( CONFIG_STATIC_SHM changes )
> >     - add shared_meminfo ( because of CONFIG_STATIC_SHM )
> >     - struct struct membanks was update with __struct group so
> > <xen/kernel> is
> >       neeeded to be included in bootfdt.h
> >     - move BOOTINFO_ACPI_INIT, BOOTINFO_SHMEM_INIT, BOOTINFO_INIT
> > to generic bootfdt.h
> >     - bootinfo_get_reserved_mem(), bootinfo_get_mem(),
> > bootinfo_get_acpi(),
> >       bootinfo_get_shmem() and bootinfo_get_shmem_extra() were
> > moved to xen/bootfdt.h
> >   - s/arm32/CONFIG_SEPARATE_XENHEAP/
> 
> I think this change deserve a comment in the commit message.
Sure, I will mention that ( IIUC only this
"s/arm32/CONFIG_SEPARATE_XENHEAP/" should be mentioned ).

> 
> [...]
> 
> > --- /dev/null
> > +++ b/xen/common/device-tree/bootinfo.c
> > @@ -0,0 +1,459 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/*
> > + * Derived from $xen/arch/arm/setup.c.
> 
> I would suggest to mention the version of Xen this is derived from.
Will it be enough only Xen version without commit hash?

> 
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks!

~ Oleksii