[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v5 09/13] x86/vmx: guard access to cpu_has_vmx_* in common code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Fri, 2 Aug 2024 13:53:04 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twp8q0lDoPWw47l5n3lTxsMj9kwYVZfhW/a8qtrss38=; b=QsyNOd7+4Kee4wK8fAY1cvu53XPuY8gtIsMhup0ZGqQsaJXyBctS3X6jPBE9zaS3y2hptqU7Ai6g/+0h/4T6ucq3WIEEea6qDotdHDTg0nck87vszB8c0lzr/AHLC9BSVPDTTpaWeKUfRRMaMVZXfDi1uGkqSMwv8FtzNQRB3LIe9QOBhAS45XBGsQ4kJ13t/uF/kLWi+YqOsTQ9nIHV5j2IoOSl1Pw2LH+1OBniRxLkbB0KsbxFndXrIG/QJqo6MYvNscFH+nVSAgoXwPSA7ZLWI8mB4Ky2zwrPw4baU0yclK0GAuIsr0XBZk0iUk7L6VUqPGDOUzxkiACzUdB0kg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OKA5tuXM5msTfUzmW+U5eciEvxgbsMJhSN4oEeeE2AopHKsqAT+RNLk4XrvYczBuLd3NFzn6347TxYyZkAr5fCFlhzMqzYyJac+I+0gFs8ipJk6HToYSDmJq/DviMpE3AJiHwrQXqMAhRpZuBu1gXaz9B9lbeBg4lngiCUzg6aaxtMSgfZVVYh3kiaiGrlE65PuIi1C/QXeyCbikiQky4uTBsML9gqjKhg0JZkm02DV4jPDhQyct4kQMQWSS4+cdfhRAwbZVr5htLCj1CFxwUw1l4fG+QYIDQOTOE33u44koJpRSUiJ8H37YqCswBx7JxOX5Vzfi3lRLous8REAL0g==
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 02 Aug 2024 10:53:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
31.07.24 15:23, Jan Beulich:
On 30.07.2024 12:33, Sergiy Kibrik wrote:
There're several places in common code, outside of arch/x86/hvm/vmx,
where cpu_has_vmx_* get accessed without checking whether VMX supported first.
These macros rely on global variables defined in vmx code, so when VMX support
is disabled accesses to these variables turn into build failures.
To overcome these failures, build-time check is done before accessing global
variables, so that DCE would remove these variables.
Signed-off-by: Sergiy Kibrik<Sergiy_Kibrik@xxxxxxxx>
Acked-by: Paul Durrant<paul@xxxxxxx>
CC: Andrew Cooper<andrew.cooper3@xxxxxxxxxx>
CC: Jan Beulich<jbeulich@xxxxxxxx>
---
changes in v5:
- change kconfig option name VMX -> INTEL_VMX
- do not change .c files, only modify macros in vmcs.h
Better, yet still not going far enough, as indicated earlier:
I must've misunderstood your earlier suggestion. Are we talking about
modifying all of cpu_has_vmx_* macros -- even though most of them used
internally to VMX code and don't cause any trouble in common code?
-Sergiy
|
