[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v12 4/7] x86/domctl: Add hypercall to set the access of x86 gsi
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 2 Aug 2024 08:23:43 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i187gn9CPcijMwA5t3I7vtgJ6MsrVrT4NuyA0N6lhTM=; b=DYKGJCQWf0SvAdW3iRgvAN7lFBpvKKMYipyh/3zLsB2ljWICAnEItHDkSKGrQvPhVXfUEcTMk/8g5/FrL151MYz4Iy+YvXRsyD8rm1ro6MptpsyuW9tmgFTxD2XHHPut8wwVHpBlZdGnjeqyJU75aUpiIr3rjArrTKMpCJkDPgbLoBoCd79hceJiGu84EKaTgki9uNqkUewrppGlbNLymryzK8avO3Aa1ZYLRbRaLjMppJpbo2SsR3qJ66zBxdvJaoDfgv24BjbttihDJX3hGDWJjG3Mi5Rkb8+jji+Ir5zrAy4Rrqptkl8j75pkfM0JZnEcI7caincSV3gh9feJag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NC9+UDxbOEA+nJ3pHEYrGoU0aboPMo+MOdMdnnNKRm/XufO8MVhNBaML4p9ma24NBz+nds5vhrfCwVvLOXnt/XTx85Ltil8fKqg4tTHtAbhwliiwnXX0lDJIH5QHpPS4lWmRv/d4eJUY+4Dtv1f2YSQP2B/93GwpPNOtnAJdDz1KOSjqu67KAElJ6n8uZaN1XTXh+mGqggC+3LZmbKJa8gylGSpgJHPxpx0igYWGCZhuk+FN1C20v2i22KYZ0jV7QbVbo89z0cqDAy9CEw6X+zfUnUPiGb5MuCNro/xt0n9k18jmbsIZwx8MScdXnxXNgs/W2kXeTc/sSyj28tdTLg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 02 Aug 2024 08:23:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHa0SvYL4tONjoIyEuzfSK6fk2TK7ITw+cAgACJIwA=
- Thread-topic: [XEN PATCH v12 4/7] x86/domctl: Add hypercall to set the access of x86 gsi
On 2024/8/2 16:08, Roger Pau Monné wrote:
> On Mon, Jul 08, 2024 at 07:41:21PM +0800, Jiqian Chen wrote:
>> Some type of domains don't have PIRQs, like PVH, it doesn't do
>> PHYSDEVOP_map_pirq for each gsi. When passthrough a device
>> to guest base on PVH dom0, callstack
>> pci_add_dm_done->XEN_DOMCTL_irq_permission will fail at function
>> domain_pirq_to_irq, because PVH has no mapping of gsi, pirq and
>> irq on Xen side.
>> What's more, current hypercall XEN_DOMCTL_irq_permission requires
>> passing in pirq to set the access of irq, it is not suitable for
>> dom0 that doesn't have PIRQs.
>>
>> So, add a new hypercall XEN_DOMCTL_gsi_permission to grant/deny
>> the permission of irq(translate from x86 gsi) to dumU when dom0
>> has no PIRQs.
>
> I've been wondering about this, and if the hypercall is strictly to
> resolve GSIs into IRQs, isn't that the case that Xen identity maps GSI
> into the IRQ space, and hence no translation is required?
Yes, for gsis that has no entries in mp_irqs, xen do the identity maps.
I will delete the words "translate .."
>
> Thanks, Roger.
--
Best regards,
Jiqian Chen.
|
