[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v12 1/7] xen/pci: Add hypercall to support reset of pcidev
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 2 Aug 2024 02:56:50 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=25+9rBOnUI33mmwEw2JICV7RQqjmPOEKfpuXev6iRKU=; b=JSl7JUpo64LLpp2FL/UylEDhSgF2PG/1eWdgKcSQtOLkl3m6Ip1eGW2pGfj6MAsB0Tzh4r7TV8mg0n9lRd9+JHMaiGQfS8yJursH6AANa8Qguq1mi3EyWZmdBabNDKG7kHxdqjKpKpmEEKkHPGGBumdTleNsVJRa5ijVUB9i914GJ5m0v2jCJxAHsBxeUX8UU72qUtwargxLX3Z4h1WUYkPxYWt0fOSjLE9zoE9SRrBWSJ+tZy1sB4yFn3UKkkU+dJUtUKn5nAPUoPCIIiqoVauqEBIAjccxFBuwtxn1TVC5UqJTcz9VR/ebX2TgQcupQqCeY2weqcH3GqRQ3l+PCQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LlB+b6Ca11NXPflWO3OFpRBl+C5A0t1rL08QHMNbIszdiwQ0h+c/1kUqyIw+ff31NGwELKOo7fifoUPL/DADBmzDCzWHZktktexoMbkdpnBSTZ/o2tBEJp6GPEaz43z1GZ3FdVyZcsXPdlLkFQ/f06eBBctubIM27BIDgwGCm1SpQPPGDqT2myzuDlFlssTxo4Tk+eQmlVmQsjUqZW08z5aEKdmZbW0lDlFE0eax1UTVUa7Zf0O2FfiVawSxmtanLHlE8Mhfd1SpflTcP0J1Lr5H0NVVtntc4hgOvtfYeQr//7tEXAmixqd9t+lAv3DsWoZd5vZS0mAdGZLFx0YvIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 02 Aug 2024 02:57:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHa0SvTLcqHcyv10kCa3wxjMJYih7IRIeaAgAAA2ACAAAQnAIAA9LaAgAHSh4A=
- Thread-topic: [XEN PATCH v12 1/7] xen/pci: Add hypercall to support reset of pcidev
On 2024/8/1 14:49, Jan Beulich wrote:
> On 31.07.2024 18:13, Roger Pau Monné wrote:
>> On Wed, Jul 31, 2024 at 05:58:54PM +0200, Jan Beulich wrote:
>>> On 31.07.2024 17:55, Roger Pau Monné wrote:
>>>> On Mon, Jul 08, 2024 at 07:41:18PM +0800, Jiqian Chen wrote:
>>>>> --- a/xen/drivers/vpci/vpci.c
>>>>> +++ b/xen/drivers/vpci/vpci.c
>>>>> @@ -172,6 +172,16 @@ int vpci_assign_device(struct pci_dev *pdev)
>>>>>
>>>>> return rc;
>>>>> }
>>>>> +
>>>>> +int vpci_reset_device_state(struct pci_dev *pdev,
>>>>> + uint32_t reset_type)
>>>>
>>>> There's probably no use in passing reset_type to
>>>> vpci_reset_device_state() if it's ignored?
>>>
>>> I consider this forward-looking. It seems rather unlikely that in the
>>> longer run the reset type doesn't matter.
>>
>> I'm fine with having it in the hypercall interface, but passing it to
>> vpci_reset_device_state() can be done once there's a purpose for it,
>> and it won't change any public facing interface.
>
> Jiqian, just to clarify: I'm okay either way.
Thank you very much! You dispelled my concerns.
I will remove reset_type in next version.
>
> Jan
--
Best regards,
Jiqian Chen.
|
