Re: [XEN PATCH v5 13/13] x86/hvm: make AMD-V and Intel VT-x support configurable

[Jan Beulich <jbeulich@xxxxxxxx>]

On 30.07.2024 12:41, Sergiy Kibrik wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -123,11 +123,25 @@ config HVM
>         If unsure, say Y.
>  
>  config AMD_SVM
> -     def_bool HVM
> +     bool "AMD-V" if EXPERT
> +     depends on HVM
> +     default HVM
> +     help
> +       Enables virtual machine extensions on platforms that implement the
> +       AMD Virtualization Technology (AMD-V).
> +       If your system includes a processor with AMD-V support, say Y.
> +       If in doubt, say Y.
>  
>  config INTEL_VMX
> -     def_bool HVM
> +     bool "Intel VT-x" if EXPERT
> +     depends on HVM
> +     default HVM
>       select ARCH_IOREQ_COMPLETION
> +     help
> +       Enables virtual machine extensions on platforms that implement the
> +       Intel Virtualization Technology (Intel VT-x).
> +       If your system includes a processor with Intel VT-x support, say Y.
> +       If in doubt, say Y.

Despite my earlier ack: It appears to make little sense to use "default HVM"
when there's also "depends on HVM". "default y" would be more clear imo, even
if just slightly.

Jan