[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v12 1/7] xen/pci: Add hypercall to support reset of pcidev
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Tue, 9 Jul 2024 02:47:56 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LDeXQlZdtdTtDFp20XkyKFDkUUWQhZWhBvYvHgoUDgQ=; b=ERdQiORR1rjqqnACp8Df9Bo7nPoeN5Avp+GiQ+sK7KA5EHS+RLvR6bPoacO3vN+HdtVD9XRUs6tpJbhdNFyzmMDRtJzi9CgVDJKZPBSU6oaWYZhBtg4ddYvZ1c1414CGNJZPeUESLfk0HB+5bFYp3al86wSiSy9yZzU+7m5VuKeojGhL7fOq+o/7A09XV9vVGJhe+plrJ74Gm2roaoqAv3eg4NyyYMdKbjs13FxN7AgcfOfaDhlBigna/Q00RrhgrnGsVlORBz3yigCM9yk+VQPwv73H43U65nsp8GI//KlFh0WqtqBb+ek797hna4BmjlB7smweNPEFBOhO4uJ16w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwdTJK3GcHxWsgEVYZRblpR+62JVabSaMYcNHC7dyuqAmVGxoSNqkWjJJV4EypgAQ+o7WZMGxK/akqrnkkZag1S4OENncX8ZR1p/aQoIt8w0qffhxkyGQ/sjE7KXhD+4AKXv+lPtxekRiOg1iC4hc6ZUXDRhWn4hCcj1E+KZrD5kkCfUfVF1NPBwwR5okg0bMd/fMzbyrA4FxVHBx86PjTB4T0yGGqiD8xnYezEtqaqX+Xc5wTH7G+pr/nUCCsCwcOchfiGDHmYrn1HczD7QucvtN95ZW6C51hrWlRPM8hOM8lanW69BhHR2DqwE8GDCYwTUE/Sph+ZLZjoMqLfSWA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Tue, 09 Jul 2024 02:48:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHa0SvTLcqHcyv10kCa3wxjMJYih7Hs67IAgAFMAYA=
- Thread-topic: [XEN PATCH v12 1/7] xen/pci: Add hypercall to support reset of pcidev
On 2024/7/8 22:56, Jan Beulich wrote:
> On 08.07.2024 13:41, Jiqian Chen wrote:
>> When a device has been reset on dom0 side, the Xen hypervisor
>> doesn't get notification, so the cached state in vpci is all
>> out of date compare with the real device state.
>>
>> To solve that problem, add a new hypercall to support the reset
>> of pcidev and clear the vpci state of device. So that once the
>> state of device is reset on dom0 side, dom0 can call this
>> hypercall to notify hypervisor.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Reviewed-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thank you very much!
>
> Just to double check: You're sure the other two R-b are still applicable,
> despite the various changes that have been made?
Will remove in next version.
>
> As a purely cosmetic remark: I think I would have preferred if the new
> identifiers didn't have "state" as a part; I simply don't think this adds
> much value, while at the same time making these pretty long.
Do you mean: remove "state" identifier on all the new codes?
>
> Jan
--
Best regards,
Jiqian Chen.
|
