[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19(?)] xen/arm: bootfdt: Fix device tree memory node probing
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 26 Jun 2024 14:42:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcGzbTMuXg2d9EQHzHL9axGsId27hZQpNGXFy4fthp4=; b=b3RiZLtIPOtwu3bclXu51Ei5MCQwmkyCFa0d/7bKc2AnJeLysk2M/1TC7P8y0EXHTSEDPa1NzGkjp5ZJcoclKuaszTDTukZsCrHPL5WTHd5d2f2Z2Nh+kao3pJClWITY29ku/s30hjdE3IK3yYNxfsIKXXQ7iQwJAcSipaBIY50q3EQyQawMWsl3uYy8LzeYLcMj+0yo8N3ahPpmqH194gYHoEoUr/eIksFv6riCKw9pboDPOCcB8IzRIgua5s/eVt5UXUMIwB8Eq4+lEVbNliBdgktkj0AgIfRHhjnNBVIdKwN5ngOL6FpCinbUjpdX9FDlQkLVO84Tm3AfMZkulg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcGzbTMuXg2d9EQHzHL9axGsId27hZQpNGXFy4fthp4=; b=aUM0DZIesrYZj3tVkj6RMpIwa1i6fcjp8FZiUDjn9wE8NU8qfypoTIly5znjNE3KX1k4HMrJwmA4TVY+fdKBtc5FFq6X/VUixZmm2x9cjH5zgKoJLPj7Xpvx4Y+34K2W6HHKQafhk2gH/aCdDORYI11PIgcz6WFVn8bPQXQJvGZaWxZBNf6lWNr2xsApnXeIgQdsgdkVe7weY1+2aTJHUaJ8jQw3vfrsBvQx/fDIGkCcwjRuxX32RVhxoKYIMm5C61jChTiE72bEHQTTIsKWy2cmx23zgrRftvAzmz1g8pBW8cNL35gMHcfab4K+pXLTzk3CGgbUafSDuiFxVfINwg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Nu+LVQZ0k8vzjwJafLHgA6xdMk/rELVIBv5vrboONJ7ASPsuaWJ2O/pL6SOEN8zvDrZ/dW72gLvn4+EQvVXTFTxvt/VmBRfu2JQiICt8//lghqFeUBpDO/7vnw4X/7hvBPuGgllZ43vXgUrmINbWsLeeuynn35eUYgENWj3Vx5AI47N81CkXVsoeKj8cRXK/lKPEzGYchaex6VqN/IzSULDbYHH/XuLJhzMPT3hquj9E2dVwutdSzPpUV+Xyq7D8m+HbZ+3lLgNqR70jfych5qvHasFZoQ/HqEqgNbocrh0NB6OOQk6EbDeZqoJnXqkSahrcylcTZe910XAt212SGQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=evJzNLgUB9mAjxim/8TE9Jt87FuorPdpkJ1fL11cFuvbli3cjo/Frq1bXkL9UbidwhMvKxB+AV+ITccdFkZH30QVA7z0wbSfUQfFUdTrFhQT25/iZ49IvwLJdCCVZN5NNkr71wzoDmRZazGHC1tydABn1c4+VEnX7DNjTut8HtUwqekS4BAVYn+gpgJo3eTd1Yxea3OO8zZI3VK4UHZemZDzzntbmJagzqNIxX4dW1cCGTQsaN/5SnVKcZ05tOJAnBQMKmRltEB4zhbJH/8zneDeVTv2zwtsIWBYYyclEpPbqy0ZHbkeUbrxj1BoAFYVrJVgS6RcYV3LhRsv8BhFUA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "oleksii.kurochko@xxxxxxxxx" <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 26 Jun 2024 14:42:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHax5+US/AJkZu/L0SR6EusLPxlorHaHseA
- Thread-topic: [PATCH for-4.19(?)] xen/arm: bootfdt: Fix device tree memory node probing
Hi Michal,
> On 26 Jun 2024, at 09:04, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Memory node probing is done as part of early_scan_node() that is called
> for each node with depth >= 1 (root node is at depth 0). According to
> Devicetree Specification v0.4, chapter 3.4, /memory node can only exists
> as a top level node. However, Xen incorrectly considers all the nodes with
> unit node name "memory" as RAM. This buggy behavior can result in a
> failure if there are other nodes in the device tree (at depth >= 2) with
> "memory" as unit node name. An example can be a "memory@xxx" node under
> /reserved-memory. Fix it by introducing device_tree_is_memory_node() to
> perform all the required checks to assess if a node is a proper /memory
> node.
>
> Fixes: 3e99c95ba1c8 ("arm, device tree: parse the DTB for RAM location and
> size")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> 4.19: This patch is fixing a possible early boot Xen failure (before main
> console is initialized). In my case it results in a warning "Shattering
> superpage is not supported" and panic "Unable to setup the directmap
> mappings".
>
> If this is too late for this patch to go in, we can backport it after the tree
> re-opens.
> ---
It looks ok to me,
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
I’ve also tested on FVP, I’ll put it through our CI and I’ll let you know.
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
