[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression
- To: Christoph Hellwig <hch@xxxxxx>
- From: Oliver Sang <oliver.sang@xxxxxxxxx>
- Date: Wed, 26 Jun 2024 14:11:11 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J8fSauy/TvO+99Vvwkl3RhAOh0VOzLNYuHGS202phAg=; b=lhiLnkbGk2lf+f7pFFALd8EuEtzimO8YXjEK42hYfcvENwx91wwmq5JGxmBTRjoYEmYDBBkLk3ACR32A0K/LcW5cm/qIwtF5rcRIyihXkGCekcGhpcL0zpfh5x6FW0DoIuVkWRguTOusniMyhsJZ73xmEZ3ZR4U34hFnuR34Tx4trQ5c+ZNU3yuaD/TEgnDrTyBegFq/9s0sm/9t74UJomkaPRQ5yAFxCxseBGWNUSmQd3P+M5Fi1u13npmCN6kSHD2CNhq4xdQwqYKoAhUOF9lh78IliQM7/1aYqN1lbSCyn0QvoEsmXCeQr5cREYjOCPtQFOr8eW8MWsUGFwbhWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJx9SUp9NndkNHVYJi4HQYyOTnLrCdT9FK7KOhxwCSlnU86VRUnAvejMi/fmDdgt1heNwZIT5KThAbnc646BUcerpKXzB1XTC1VBoyFfCK7tZ44BmHIu7NdmvJct9HRvVnmOGf/luVOElAHzXP2nWs6t78/139wCY5BPdtN2JJFhQayuDfxdw5oBSozXvHPuhdLIWxFMmI6bYy4/zhP8AJw/63gIk/7zNpgNRYnLPYsB0ksNrkX2VLj8kM4LPk5yr1NQq3gLuTM2HSAlgoQZuxw1u21OIjEYxftExrOcn0eKrHa1EQsUJz+RIiqItQ141Lgs6b+lwuUJrnphrvPqrA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: <oe-lkp@xxxxxxxxxxxxxxx>, <lkp@xxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, <linux-m68k@xxxxxxxxxxxxxxxxxxxx>, <linux-um@xxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, <drbd-dev@xxxxxxxxxxxxxxxx>, <nbd@xxxxxxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, <ceph-devel@xxxxxxxxxxxxxxx>, <virtualization@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-bcache@xxxxxxxxxxxxxxx>, <dm-devel@xxxxxxxxxxxxxxx>, <linux-raid@xxxxxxxxxxxxxxx>, <linux-mmc@xxxxxxxxxxxxxxx>, <linux-mtd@xxxxxxxxxxxxxxxxxxx>, <nvdimm@xxxxxxxxxxxxxxx>, <linux-nvme@xxxxxxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <ying.huang@xxxxxxxxx>, <feng.tang@xxxxxxxxx>, <fengwei.yin@xxxxxxxxx>, <oliver.sang@xxxxxxxxx>
- Delivery-date: Wed, 26 Jun 2024 06:11:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
hi, Christoph Hellwig,
On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote:
> This is odd to say at least. Any chance you can check the value
> of /sys/block/$DEVICE/queue/rotational for the relevant device before
> and after this commit? And is this an ATA or NVMe SSD?
>
yeah, as Niklas mentioned, it's an ATA SSD.
I checked the /sys/block/$DEVICE/queue/rotational before and after this commit,
both show '0'. not sure if this is expected.
anyway, I noticed you send a patch [1]
so I applied this patch upon bd4a633b6f, and found the performance restored.
=========================================================================================
compiler/cpufreq_governor/disk/filesize/fs2/fs/iterations/kconfig/nr_directories/nr_files_per_directory/nr_threads/rootfs/sync_method/tbox_group/test_size/testcase:
gcc-13/performance/1SSD/9B/nfsv4/btrfs/1x/x86_64-rhel-8.3/16d/256fpd/32t/debian-12-x86_64-20240206.cgz/fsyncBeforeClose/lkp-ivb-2ep2/400M/fsmark
commit:
1122c0c1cc ("block: move cache control settings out of queue->flags")
bd4a633b6f ("block: move the nonrot flag to queue_limits")
e9a0f6a398 = bd4a633b6f + patch [1]
1122c0c1cc71f740 bd4a633b6f7c3c6b6ebc1a07317 e9a0f6a398f162d115d208ad95b
---------------- --------------------------- ---------------------------
%stddev %change %stddev %change %stddev
\ | \ | \
4177 ± 2% -64.7% 1475 -1.1% 4130
fsmark.files_per_sec
[1] https://lore.kernel.org/all/20240624173835.76753-1-hch@xxxxxx/
|
