Re: [PATCH v13 03/10] xen/riscv: add minimal stuff to mm.h to build full Xen

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Tue, 2024-06-25 at 16:22 +0200, Jan Beulich wrote:
> On 25.06.2024 15:51, Oleksii Kurochko wrote:
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > Changes in V13:
> >  - redefine mfn_to_page() and mfn_to_page().
> 
> DYM page_to_mfn() here as one of the two?
Yes, one of them is page_to_mfn(). I will update the comment in next
version.

> 
> > +/* Convert between machine frame numbers and page-info structures.
> > */
> > +#define mfn_to_page(mfn)    (frame_table + mfn_x(mfn))
> > +#define page_to_mfn(pg)     _mfn((unsigned long)((pg) -
> > frame_table))
> 
> Is the cast really needed here?
I checked and it can be really dropped.

~ Oleksii