Re: [XEN PATCH v2] automation/eclair: configure Rule 13.6 and custom service B.UNEVALEFF

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2024-06-24 at 17:26 -0700, Stefano Stabellini wrote:
> On Mon, 24 Jun 2024, Stefano Stabellini wrote:
> > On Mon, 24 Jun 2024, Federico Serafini wrote:
> > > Rule 13.6 states that "The operand of the `sizeof' operator shall
> > > not
> > > contain any expression which has potential side effects".
> > > 
> > > Define service B.UNEVALEFF as an extension of Rule 13.6 to
> > > check for unevalued side effects also for typeof and alignof
> > > operators.
> > > 
> > > Update ECLAIR configuration to deviate uses of BUILD_BUG_ON and
> > > alternative_v?call[0-9] for both Rule 13.6 and B.UNEVALEFF.
> > > 
> > > Add service B.UNEVALEFF to the accepted.ecl guidelines to check
> > > "violations" in the weekly analysis.
> > > 
> > > Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> > > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 
> Hi Oleksii,
Hi Stefano,

> 
> I am asking for a release-ack on this rule: it widens the checks done
> by
> ECLAIR but only for non-blocking rules (a rule not causing a gitlab-
> ci
> failure). Hence, there should be no effect on gitlab-ci.
Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

~ Oleksii