[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3



On 24/06/24 17:43, Jan Beulich wrote:
On 24.06.2024 11:04, Federico Serafini wrote:
Add missing break statement to address a violation of MISRA C Rule 16.3
("An unconditional `break' statement shall terminate every
switch-clause").

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm curious though on what basis you decided to split this off of
patch 7, ...

---
  xen/arch/x86/hvm/pmtimer.c | 1 +
  1 file changed, 1 insertion(+)

... touching various other files under xen/arch/x86/hvm/.

Looking at the log I found some commits where the component
name was made explicit.
I can squash it into patch 7 in a v3.

--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.