[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19] xen/arm: static-shmem: request host address to be specified for 1:1 domains
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 24 Jun 2024 12:43:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vX/XPk4ZNl3GC0+OAmhrZeBaM3J8/ewr8h32CY/Guy0=; b=Q+ffqqvwZeuvOQD1fHGrraephcjgxHe5wKeY4v9gNxUJiacnbPhu3D0K8UNN1JkBNU7WjOslSMYLmoD9gubKs6Z3udjS4d9bQ8WsBRI1kNIkbxaxVQGcMoNBgv+xg9Jv3Kkvr1a1j3tklvGjmMz4mOPQ7kkD/GTw1t1zi85EfG+lckv5YRgn6HVarmg+DaItbkShgvUZTM6qijFUDiw+7f1hxA/G5WFiGhrrbAryc4HGipo/yWgVywm8ne7LewydW4x9p1AAVtTjMRyFcDO/rpdYgmhTwPLBPYmPa5Gn4ua5KgyWSYw9rbJYCSft2cpxBwi0K0jj5Y1psxAypEvq0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKtVPJuuK57ClXBeFYLhdwtK3RKSi93zm6TG19OO4k6fR8l59bxVgFX1tlvvTb8h3RZpHMreX1ojenY+HmlDrCBnAMNs1R7ipHY13NCR23MROC83gx6mWlokJZ3bXi3IlD0Hql20bMlUiOj755ZKF2UerXa5RRLqKp/cAdHAQhiOcDI19XR0FCdl/tsqzFK7ReAcl9ivjCdGjWUBTJHo1cqy5DPfuJ2MdjvC5aaivUW9Ib+37u45XHm8ELCjTalxVwOyrGKsIqOCSZQydQInQKgIcBcXgecIYxEqIdWDejIvEyYlye7hnhvU30h/3lYyJ/VblPGTEH53rP7tuOn5Xg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 24 Jun 2024 10:43:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 24/06/2024 12:22, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 21/06/2024 10:22, Michal Orzel wrote:
>> As a follow up to commit cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem
>> should be direct-mapped for direct-mapped domains") add a check to
>> request that both host and guest physical address must be supplied for
>> direct mapped domains. Otherwise return an error to prevent unwanted
>> behavior.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> I would argue that it should be have a fixes tag:
>
> Fixes: 988f1c7e1f40 ("xen/arm: static-shmem: fix "gbase/pbase used
> uninitialized" build failure")
>
> Mainly because while you fixed the build, it was missing the check in
> the "else" part.
>
> I am happy to update it on commit if you are ok with the change.Yes, I'm fine
> with it.
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Cheers,
>
> --
> Julien Grall
~Michal
|
