Re: [PATCH] automation/eclair_analysis: deviate common/unlzo.c for MISRA Rule 7.3

[Alessandro Zucchelli <alessandro.zucchelli@xxxxxxxxxxx>]

On 2024-06-20 03:17, Stefano Stabellini wrote:
> On Tue, 18 Jun 2024, Jan Beulich wrote:
> > On 18.06.2024 11:54, Alessandro Zucchelli wrote:
> > > The file contains violations of Rule 7.3 which states as following: The
> > > lowercase character `l' shall not be used in a literal suffix.
> > >
> > > This file defines a non-compliant constant used in a macro expanded in a
> > > non-excluded file, so this deviation is needed in order to avoid
> > > a spurious violation involving both files.
> >
> > Imo it would be nice to be specific in such cases: Which constant? And
> > which macro expanded in which file?
> Hi Alessandro,
> if you give me the details, I could add it to the commit message on 
> commit
Hi,

The file common/unlzo.c defines the non-compliant constant 
LZO_BLOCK_SIZE as
"256*1024l" (note the 'l'). This file is excluded from ECLAIR analysis 
but
as the constant is used in macro xmalloc_bytes, expanded in non-excluded 
file
include/xen/xmalloc.h, thus these specific violations need this 
configuration
in order to be excluded.

--
Alessandro Zucchelli, B.Sc.

Software Engineer, BUGSENG (https://bugseng.com)