Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility

["Oleksii K." <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2024-06-19 at 14:33 +0000, Anthony PERARD wrote:
> On Wed, Jun 19, 2024 at 02:07:04PM +0200, Jan Beulich wrote:
> > On 16.05.2024 15:52, Jason Andryuk wrote:
> > > On 2024-05-16 03:41, Jan Beulich wrote:
> > > > On 16.05.2024 04:22, Jason Andryuk wrote:
> > > > > From: Jason Andryuk <jason.andryuk@xxxxxxx>
> > > > > 
> > > > > From: Jason Andryuk <jason.andryuk@xxxxxxx>
> > > > 
> > > > Two identical From: (also in another patch of yours, while in
> > > > yet another one
> > > > you have two _different_ ones, when only one will survive into
> > > > the eventual
> > > > commit anyway)?
> > > 
> > > Sorry about that.  Since I was sending from my gmail account, I
> > > thought 
> > > I needed explicit From: lines to ensure the authorship was listed
> > > w/ 
> > > amd.com.  I generated the patches with `git format-patch --from`,
> > > to get 
> > > the explicit From: lines, and then sent with `git send-email`. 
> > > The 
> > > send-email step then inserted the additional lines.  I guess it
> > > added 
> > >  From amd.com since I had changed to that address in .gitconfig.
> > > 
> > > > > backendtype=phy using the blktap kernel module needs to use
> > > > > write_dev,
> > > > > but tapback can't support that.  tapback should perform
> > > > > better, but make
> > > > > the script compatible with the old kernel module again.
> > > > > 
> > > > > Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> > > > 
> > > > Should there be a Fixes: tag here?
> > > 
> > > That makes sense.
> > > 
> > > Fixes: 76a484193d ("hotplug: Update block-tap")
> > 
> > Surely this wants going into 4.19? Thus - Anthony, Oleksii?
> 
> Yes, I think so.
> 
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

~ Oleksii