[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.19] livepatch: use appropriate type for buffer offset variables



On Thu, Jun 20, 2024 at 8:16 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> As was made noticeable by the last of the commits referenced below,
> using a fixed-size type for such purposes is not only against
> ./CODING_STYLE, but can lead to actual issues. Switch to using size_t
> instead, thus also allowing calculations to be lighter-weight in 32-bit
> builds.
>
> No functional change for 64-bit builds.
>
> Link: https://gitlab.com/xen-project/xen/-/jobs/7136417308
> Fixes: b145b4a39c13 ("livepatch: Handle arbitrary size names with the list 
> operation")
> Fixes: 5083e0ff939d ("livepatch: Add metadata runtime retrieval mechanism")
> Fixes: 43d5c5d5f70b ("xen: avoid UB in guest handle arithmetic")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>

Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Thanks



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.