[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19] xen/arm: static-shmem: fix "gbase/pbase used uninitialized" build failure
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 19 Jun 2024 09:01:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=17QQVv9ErczK1oQcsp8u/TK83FSQzoafjA3Kjd6F1bA=; b=C216jVECgkdSqQ2x5ArORrTUOy07kEs6VzvOQYPmI09lSCSLYxUsCr51xeHURVhULJX6ZC6XdXtFggU9BbtFfCpDr+gMoZqKkCPqxZ4/LogYEo28uOrp0roJ4HuSkwoNlu8lniWBrT/WENk4hbFaaRmFiMei5qVtwbdzFpZ/7BhXRb740myLhPnRz8Q6SsjWyp/qkOKfHwQ9Hdns1vJhiEpSw1U11tsH+8DfgBpzYbwAvz9ZS3hV11yICKYbl12Q8REmj/Ko5Lwg5JfCzwdfAeGlRaGgjv6yz2xfkseZ9TgZkXF9dr35Xet4YBhx6pjsYeIMjnhMeV9lJ+NzyrExYQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=17QQVv9ErczK1oQcsp8u/TK83FSQzoafjA3Kjd6F1bA=; b=FOUk6oZERtFlu5wJ4IydJCe8aIuK0PeulXBqs9ekzTYjckFz1CV7TBYB56f0Z7Bu5CRLKvTAtHsy74PHMWgDWJVmS5QR3qP5+wabODjd/HmQW291BZgCklcUVs7RO7LaZU1b0JicR/4lxgab7tt9gTOxOorUg4KGgA8UFqR0JgcUWjUtsSSBEkMjw5f4vEVx73nv/GzbgA1LXEemLIUSyMfJeJHrEv8mMnmLUTnkc5TTT2tFoJiTci2wHivnLZ1wjgz/ox8RQ07YJjYBqzPZPxq3UbqmyinS+lRE+1CwT1sIJhXqCjRy4A2w4L6GtVZEM3QZm1Kaf4qroxdUK57DXA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gEsJ6G2y9HNJVn5SfkkJvIJyQjf6CFt5s5hf8dUFcgsOC3HyVmokWfoZ4myla4bD0pfGQ0maqgrE38WHSrIly90mzOSJihXHqCoAbEeEPX4XU1BSplhCkKasSRcT6x/hmKb0U1X6gg0Bh0Qd6CNElL9ZlKMU0zWnabWGVcHekLQkYSVSwVcXbHY3g/kaQFoav4P0JQTn7yaUL3R6+7LY0r7Yjrio98QzolHsX8Mko6QK3HgJXBY1JFbIvlvKyT6ZM0Bd3VFbq3Lfhmh8LBJ1FtOMJNduv4ksn9Ps6qWgyvsiOhCOi9Jdevc9QZatnlLcYQ97/9NbkkAnTeMyEDxquA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/psGmLUNgkQ+terNqBgJomWx4FVlDbK/g36hVKT2L8yqyDvK6gP62ETBP/QFsS4hlWzVjDTB6cnxj2G5RQouJFWXeC0JXA+NY7Y9cwcrO7MYbdOQneTle+ZLZVBTReiSQdEcvf4SOTyHLveglj8T9ZZqc/kWOK7MmooD5i/HqqFgD3C/n7Gm3zycqO2lLKXIFqFM384MMO81D87rWHgzXfb+87eKvBiWCRrMQwraeLhBr46+70rELg2wLfYIEAv3uiVwx12Fi7ojoPCeGUjNlXPX0ti9QVf66E5469gHLUyAZ2v3CDkzyIpbhgZO7S6Exne/x6HjWTPQ1CguptWCQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 19 Jun 2024 09:02:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHawhSD1mJnwmtkoE+LLMyZ3OtgsbHOym6A
- Thread-topic: [PATCH for-4.19] xen/arm: static-shmem: fix "gbase/pbase used uninitialized" build failure
Hi Michal,
> On 19 Jun 2024, at 08:46, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Building Xen with CONFIG_STATIC_SHM=y results in a build failure:
>
> arch/arm/static-shmem.c: In function 'process_shm':
> arch/arm/static-shmem.c:327:41: error: 'gbase' may be used uninitialized
> [-Werror=maybe-uninitialized]
> 327 | if ( is_domain_direct_mapped(d) && (pbase != gbase) )
> arch/arm/static-shmem.c:305:17: note: 'gbase' was declared here
> 305 | paddr_t gbase, pbase, psize;
>
> This is because the commit cb1ddafdc573 adds a check referencing
> gbase/pbase variables which were not yet assigned a value. Fix it.
>
> Fixes: cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem should be
> direct-mapped for direct-mapped domains")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Rationale for 4.19: this patch fixes a build failure reported by CI:
> https://gitlab.com/xen-project/xen/-/jobs/7131807878
> ---
> xen/arch/arm/static-shmem.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/xen/arch/arm/static-shmem.c b/xen/arch/arm/static-shmem.c
> index c434b96e6204..cd48d2896b7e 100644
> --- a/xen/arch/arm/static-shmem.c
> +++ b/xen/arch/arm/static-shmem.c
> @@ -324,12 +324,6 @@ int __init process_shm(struct domain *d, struct
> kernel_info *kinfo,
> printk("%pd: static shared memory bank not found: '%s'", d,
> shm_id);
> return -ENOENT;
> }
> - if ( is_domain_direct_mapped(d) && (pbase != gbase) )
> - {
> - printk("%pd: physical address 0x%"PRIpaddr" and guest address
> 0x%"PRIpaddr" are not direct-mapped.\n",
> - d, pbase, gbase);
> - return -EINVAL;
> - }
>
> pbase = boot_shm_bank->start;
> psize = boot_shm_bank->size;
> @@ -353,6 +347,13 @@ int __init process_shm(struct domain *d, struct
> kernel_info *kinfo,
> /* guest phys address is after host phys address */
> gbase = dt_read_paddr(cells + addr_cells, addr_cells);
>
> + if ( is_domain_direct_mapped(d) && (pbase != gbase) )
> + {
> + printk("%pd: physical address 0x%"PRIpaddr" and guest
> address 0x%"PRIpaddr" are not direct-mapped.\n",
> + d, pbase, gbase);
> + return -EINVAL;
> + }
> +
> for ( i = 0; i < PFN_DOWN(psize); i++ )
> if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) )
> {
> --
> 2.25.1
>
|
