[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/14] sd: simplify the disable case in sd_config_discard


  • To: Christoph Hellwig <hch@xxxxxx>
  • From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
  • Date: Thu, 13 Jun 2024 21:43:06 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83/oQlKqI0WIriuOwqQN/8vWAiDrwoYh8lQRRYbJelM=; b=Mzodl4+jOB3iSjnh9C7ouUrY0YPni9HSnOfxnCBpRh3scyDWjQvtisA8KB/xmMG7tDs7k0GD8eXEtf2WfRGCFCTi6DO3T0tC1Ku9YByWdJLyFkF6U7tqeiI7rMj7MukSdGJWPq1ggA/W8AiEgjEsd7VqOlp8EN6EKwN4eWolE5Imz+DGynDRYPlRrYyxLs2fbhdDmpNS5xJepM0tDHAjsjW1HTB6HcW1+0dxWb/ejNcCYjLYlArnEeHKqf9vPZZkNVITdEyfcmHTKXF3BrM8IoUJv3aAlZ/imREUsoCUwnYiq0tgHFmsNSyYmh4qK6zVMyN89mu/9cAYf/75ENx0kQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4XIjfkf0M73Qwe6rGb4w91fAv4ZF6psgZMW7U08hTgs4TS/poxp02YNX6Bc4Hrz1PsdQBtdyhLH0MT+jlyvZnaXxqq+ozkjHaSIFu7anHoiLzx6eWGKzkoNVxc2kv3JbfQlX4iLA+uEAG9q20ev/VQmYQ/dDOLW/asUulaK8lSNXP9JLJ08Wop1ohvNwMeE/QVf4BfYsWisCyT5R8CoETWd7KUOpX+3iaPucuYXsj4NqZIFMXtGkm45twOF2Qmvn+BeA221ky2DiNksZUVA3fKjfGIG6EqEK0o2HHS/VryIH5Ep6YBTqVH8n5YwE6xF5fP5EcH8HoICSA+IIqj0qQ==
  • Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Jun 2024 01:43:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Christoph,

> Fall through to the main call to blk_queue_max_discard_sectors given
> that max_blocks has been initialized to zero above instead of
> duplicating the call.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen      Oracle Linux Engineering



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.