[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Wed, 12 Jun 2024 10:15:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vc/18CKA6D5qLuF90oPGG3kp6+92Km7slGuHcaPIoRA=; b=hfkgQGXNdwS8H00RWCC+57OC0uznQSJ2sGU1xXrwJ5VKIcOjGHtxvVAPkEAPCvnytXI6IV+h+3mTrnIGgxznfRVsH5DB8J6pkx1RCuLrvbbt18pDXyDOQmHEm5Mef0q8Xf3/Fveka5pm2XQXvmT54FH9F/TOkvZw5mDPjL3+MqZABf6TxzghrfLBPQmXy8D0Y4KybTYKaCTORnR2KdicI97p8s2YthUhKYsbTTEE7FSirUSIwXlKWsYCl0/SufIHwGKL2ayztkUC9xBE2elK6aI0m0HolEllWhL5zka7N9fl+AXmeRNMcCr6ChitUb5ud+G6UbDbrS8qPte28Ld20A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ga0G6YRXj16i4+m+3h6WdqQNWKvqm/QFxVLS+TI0cZb2OLQ7obBlVQaW7OWgx2xOSYd0O5n/7z3ff5UvgYLyxq3m7Tj327cY1ZjHVzOTiO2AG/BFeMAdStzXY3LjzYUG0aUxoMOSFMiJqMbLKkuwkCHwBHBYCilCryCadxMmWB9Ca+NjxemeeqSATL3sMyDOeUJGP9NJSD8k3HPFhj4s08/gcl0LCTy8qBR2yE/p75BYmmF2N2zaqWDLXBXewJSC/IhTzleijCiqfO3aucj/QyYqo5FdgMcu7wZnukls2wzmlsQ1i2Gt/ERCBp3NfwBTNbDDYM5rORJVWo49ZwcC2g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Wed, 12 Jun 2024 10:16:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHauLJiOTCaFyDADkao1O0TqexhE7HBLmwAgALLiIA=
- Thread-topic: [XEN PATCH v9 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0
On 2024/6/11 00:04, Jan Beulich wrote:
> On 07.06.2024 10:11, Jiqian Chen wrote:
>> On PVH dom0, the gsis don't get registered, but
>> the gsi of a passthrough device must be configured for it to
>> be able to be mapped into a hvm domU.
>> On Linux kernel side, it calles PHYSDEVOP_setup_gsi for
>> passthrough devices to register gsi when dom0 is PVH.
>
> "it calls" implies that ...
>
>> So, add PHYSDEVOP_setup_gsi for above purpose.
>>
>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> ---
>> The code link that will call this hypercall on linux kernel side is as
>> follows
>> https://lore.kernel.org/lkml/20240607075109.126277-3-Jiqian.Chen@xxxxxxx/T/#u
>
> ... the code only to be added there would already be upstream. As I think the
> hypervisor change wants to come first, this part of the description will want
> re-wording to along the lines of "will need to" or some such.
Thanks, I will change in next version.
>
> As to GSIs not being registered: If that's not a problem for Dom0's own
> operation, I think it'll also want/need explaining why what is sufficient for
> Dom0 alone isn't sufficient when pass-through comes into play.
OK, I will add in next version.
>
> Jan
--
Best regards,
Jiqian Chen.
|
