[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 0/5] Support device passthrough when dom0 is PVH on Xen
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Wed, 12 Jun 2024 02:33:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KasVo+XhgybeRV6E11VQ8Riy9H2SSGjPWcryqoqwTnw=; b=Ak3C5MUfuSZ5s6IyJhZWTTFaIIcIWIDfJy3wmvtk12i+rS1t0d2XctCPxJyIp5bIBt7vbNMbhUk27Nor9LvPrQK4U+Q7EYpjTEaUpsiKOvANYpAOTkK4Ow2Eak26OQd862+eSMHk2DTsPNDGvEH4U793QZYjLpueC10dPiF8CsIIKnIzsS6Z5jPwJNOK3VDK4092BiWFEMn/0FIg1mjoqRU731HEXE4pfa4W/wvqcuUUj4KaEY1fKrd9IiLXzPGIogNMEQWd4UXXama4fuhWkdDmx9YBCrB/ggHZohPAwhMRNgNgbWDyq8/i+twFfeyuBZCc/F30oHCyjhS2VyAkiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLx4IXGQUDRKVpSyIxXmeaapRYSPUyCs3EPtRcD3/+yvU4eJsk7mYk/XrMuPFeW6zCEKYJ+8RCZ2MucKTl2jbuUb5PB9VQRHTaJQkcbBQCE4qb0nC77BArqNOhulTrpB03CcN8ZL2g63PbZdxsfMD5gCY1ap8/fHjrbKC42/TFDElWtcyshxbHBOH9wHzkBTPQJMYLzPjGoCK0eFTTOU73vKee0rBQezMi8Zxw0YcZse4ySxBqIx9qVOJpGh9pRILb+Xye1m8EFCvdKzact70kci6291lLzAnOxUBGbRpYlOXX7/rhaJZeM0EbVs2PsilXOK5l/3G4sbuZRPW3ydCQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Wed, 12 Jun 2024 02:34:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHauLJeUet4FsoIl0WzirfdjEDvvLHBLy8AgALGaAA=
- Thread-topic: [XEN PATCH v9 0/5] Support device passthrough when dom0 is PVH on Xen
On 2024/6/11 00:07, Jan Beulich wrote:
> On 07.06.2024 10:11, Jiqian Chen wrote:
>> Hi All,
>> This is v9 series to support passthrough when dom0 is PVH
>> v8->v9 changes:
>> * patch#1: Move pcidevs_unlock below write_lock, and remove
>> "ASSERT(pcidevs_locked());" from vpci_reset_device_state;
>> Add pci_device_state_reset_type to distinguish the reset types.
>> * patch#2: Add a comment above PHYSDEVOP_map_pirq to describe why need this
>> hypercall.
>> Change "!is_pv_domain(d)" to "is_hvm_domain(d)", and "map.domid
>> == DOMID_SELF" to "d == current->domian".
>> * patch#3: Remove the check of PHYSDEVOP_setup_gsi, since there is same
>> checke in below.
>
> Having looked at patch 3, what check(s) is (are) being talked about here?
> It feels as if to understand this revision log entry, one would still need
> to go back to the earlier version. Yet the purpose of these is that one
> (preferably) wouldn't need to do so.
Sorry, it should be:
patch#3: Remove the check of PHYSDEVOP_setup_gsi, since there is same check in
below. Although their return values are different, this difference is
acceptable for the sake of code consistency
if ( !is_hardware_domain(currd) )
return -ENOSYS;
break;
I will change in next version.
>
> Jan
--
Best regards,
Jiqian Chen.
|
