Re: [PATCH for-4.19? v6 3/9] xen: Refactor altp2m options into a structured format

[Petr Beneš <w1benny@xxxxxxxxx>]

On Tue, Jun 11, 2024 at 11:14 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 11.06.2024 10:00, Petr Beneš wrote:
> > On Tue, Jun 11, 2024 at 8:41 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>
> >> On 10.06.2024 19:10, Petr Beneš wrote:
> >>> From: Petr Beneš <w1benny@xxxxxxxxx>
> >>>
> >>> Encapsulate the altp2m options within a struct. This change is preparatory
> >>> and sets the groundwork for introducing additional parameter in subsequent
> >>> commit.
> >>>
> >>> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
> >>> Acked-by: Julien Grall <jgrall@xxxxxxxxxx> # arm
> >>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> # hypervisor
> >>
> >> Looks like you lost Christian's ack for ...
> >>
> >>> ---
> >>>  tools/libs/light/libxl_create.c     | 6 +++---
> >>>  tools/ocaml/libs/xc/xenctrl_stubs.c | 4 +++-
> >>
> >> ... the adjustment of this file?
> >
> > In the cover email, Christian only acked:
> >
> >> tools/ocaml/libs/xc/xenctrl.ml       |   2 +
> >> tools/ocaml/libs/xc/xenctrl.mli      |   2 +
> >> tools/ocaml/libs/xc/xenctrl_stubs.c  |  40 +++++++---
>
> Right, but above I was talking about the last of these three files.
>
> Jan

Ouch. It didn't occur to me that Ack on cover email acks each of the
files in every separate patch. My thinking was it acks only the
patches where those three are together. Anyway, it makes sense. I'll
resend v7.

P.