[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd
- To: Damien Le Moal <dlemoal@xxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 11 Jun 2024 07:54:53 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Christoph B??hmwalder <christoph.boehmwalder@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monn?? <roger.pau@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 11 Jun 2024 05:54:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jun 11, 2024 at 02:53:19PM +0900, Damien Le Moal wrote:
> > + /* reset the block size to the default */
> > + lim = queue_limits_start_update(lo->lo_queue);
> > + lim.logical_block_size = 512;
>
> Nit: SECTOR_SIZE ? maybe ?
Yes. I was following the existing code, but SECTOR_SIZE is probably
a better choice here.
|
