[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 10/16] x86/domain: guard svm specific functions with usinc_svm macro
- To: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 10 Jun 2024 17:10:09 +0200
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 10 Jun 2024 15:10:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.06.2024 13:26, Sergiy Kibrik wrote:
> From: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>
> Replace cpu_has_svm check with using_svm, so that not only SVM support in CPU
> gets checked, but also presence of functions svm_load_segs() and
> svm_load_segs_prefetch() in the build checked as well.
>
> Since SVM depends on HVM, it can be used alone.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
The code you're touching is solely for PV, even if it's interacting with HVM
code. Therefore "x86/PV:" may be the better subject prefix.
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -1731,11 +1731,9 @@ static void load_segments(struct vcpu *n)
> if ( !(n->arch.flags & TF_kernel_mode) )
> SWAP(gsb, gss);
>
> -#ifdef CONFIG_HVM
> - if ( cpu_has_svm && (uregs->fs | uregs->gs) <= 3 )
> + if ( using_svm && (uregs->fs | uregs->gs) <= 3 )
> fs_gs_done = svm_load_segs(n->arch.pv.ldt_ents,
> LDT_VIRT_START(n),
> n->arch.pv.fs_base, gsb, gss);
> -#endif
> }
>
> if ( !fs_gs_done )
> @@ -2048,9 +2046,9 @@ static void __context_switch(void)
>
> write_ptbase(n);
>
> -#if defined(CONFIG_PV) && defined(CONFIG_HVM)
> +#if defined(CONFIG_PV)
In such a case, would you mind switching (back) to the shorter "#ifdef" form?
Then
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
> /* Prefetch the VMCB if we expect to use it later in the context switch
> */
> - if ( cpu_has_svm && is_pv_64bit_domain(nd) && !is_idle_domain(nd) )
> + if ( using_svm && is_pv_64bit_domain(nd) && !is_idle_domain(nd) )
> svm_load_segs_prefetch();
> #endif
>
|
