Re: [PATCH] xen: xen-pciback: Export a bridge and all its children as per TODO

[kernel test robot <lkp@xxxxxxxxx>]

Hi Abhinav,

kernel test robot noticed the following build errors:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on linus/master v6.10-rc3 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Abhinav-Jain/xen-xen-pciback-Export-a-bridge-and-all-its-children-as-per-TODO/20240610-024623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
patch link:    
https://lore.kernel.org/r/20240609184410.53500-1-jain.abhinav177%40gmail.com
patch subject: [PATCH] xen: xen-pciback: Export a bridge and all its children 
as per TODO
config: arm64-defconfig 
(https://download.01.org/0day-ci/archive/20240610/202406101511.hTO5m855-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20240610/202406101511.hTO5m855-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202406101511.hTO5m855-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/xen/xenbus.h:37,
                    from drivers/xen/xen-pciback/xenbus.c:15:
   drivers/xen/xen-pciback/xenbus.c: In function 'xen_pcibk_export_device':
>> drivers/xen/xen-pciback/xenbus.c:270:38: error: 'struct pci_dev' has no 
>> member named 'domain'
     270 |                                 child->domain, child->bus->number,
         |                                      ^~
   include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk'
     129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);         
   \
         |                                                ^~~~~~~~~~~
   drivers/xen/xen-pciback/xenbus.c:268:25: note: in expansion of macro 
'dev_dbg'
     268 |                         dev_dbg(&pdev->xdev->dev,
         |                         ^~~~~~~
   drivers/xen/xen-pciback/xenbus.c:275:60: error: 'struct pci_dev' has no 
member named 'domain'
     275 |                                                       child->domain,
         |                                                            ^~
   drivers/xen/xen-pciback/xenbus.c:284:46: error: 'struct pci_dev' has no 
member named 'domain'
     284 |                                         child->domain,
         |                                              ^~
   include/linux/dev_printk.h:110:37: note: in definition of macro 
'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                    
   \
         |                                     ^~~~~~~~~~~
   drivers/xen/xen-pciback/xenbus.c:281:33: note: in expansion of macro 
'dev_err'
     281 |                                 dev_err(&pdev->xdev->dev,
         |                                 ^~~~~~~


vim +270 drivers/xen/xen-pciback/xenbus.c

   225  
   226  static int xen_pcibk_export_device(struct xen_pcibk_device *pdev,
   227                                   int domain, int bus, int slot, int 
func,
   228                                   int devid)
   229  {
   230          struct pci_dev *dev;
   231          int err = 0;
   232  
   233          dev_dbg(&pdev->xdev->dev, "exporting dom %x bus %x slot %x func 
%x\n",
   234                  domain, bus, slot, func);
   235  
   236          dev = pcistub_get_pci_dev_by_slot(pdev, domain, bus, slot, 
func);
   237          if (!dev) {
   238                  err = -EINVAL;
   239                  xenbus_dev_fatal(pdev->xdev, err,
   240                                   "Couldn't locate PCI device "
   241                                   "(%04x:%02x:%02x.%d)! "
   242                                   "perhaps already in-use?",
   243                                   domain, bus, slot, func);
   244                  goto out;
   245          }
   246  
   247          err = xen_pcibk_add_pci_dev(pdev, dev, devid,
   248                                      xen_pcibk_publish_pci_dev);
   249          if (err)
   250                  goto out;
   251  
   252          dev_info(&dev->dev, "registering for %d\n", 
pdev->xdev->otherend_id);
   253          if (xen_register_device_domain_owner(dev,
   254                                               pdev->xdev->otherend_id) 
!= 0) {
   255                  dev_err(&dev->dev, "Stealing ownership from dom%d.\n",
   256                          xen_find_device_domain_owner(dev));
   257                  xen_unregister_device_domain_owner(dev);
   258                  xen_register_device_domain_owner(dev, 
pdev->xdev->otherend_id);
   259          }
   260  
   261          /* Check if the device is a bridge and export all its children 
*/
   262          if ((dev->hdr_type && PCI_HEADER_TYPE_MASK) == 
PCI_HEADER_TYPE_BRIDGE) {
   263                  struct pci_dev *child = NULL;
   264  
   265                  /* Iterate over all the devices in this bridge */
   266                  list_for_each_entry(child, &dev->subordinate->devices,
   267                                  bus_list) {
   268                          dev_dbg(&pdev->xdev->dev,
   269                                  "exporting child device 
%04x:%02x:%02x.%d\n",
 > 270                                  child->domain, child->bus->number,
   271                                  PCI_SLOT(child->devfn),
   272                                  PCI_FUNC(child->devfn));
   273  
   274                          err = xen_pcibk_export_device(pdev,
   275                                                        child->domain,
   276                                                        
child->bus->number,
   277                                                        
PCI_SLOT(child->devfn),
   278                                                        
PCI_FUNC(child->devfn),
   279                                                        devid);
   280                          if (err) {
   281                                  dev_err(&pdev->xdev->dev,
   282                                          "failed to export child device 
: "
   283                                          "%04x:%02x:%02x.%d\n",
   284                                          child->domain,
   285                                          child->bus->number,
   286                                          PCI_SLOT(child->devfn),
   287                                          PCI_FUNC(child->devfn));
   288                                  goto out;
   289                          }
   290                  }
   291          }
   292  out:
   293          return err;
   294  }
   295  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki