[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v1] x86/cpufreq: separate powernow/hwp cpufreq code


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
  • Date: Thu, 6 Jun 2024 10:30:09 +0300
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zUtPU55NXqE4SI1MEQTwSG3nl6/RUMeNXZ23bFy+jt8=; b=kg6x2t3Ycj7n15zFSZGIg6wYxinQ0Wj9j2Z7hO+o3XefjeXvOpHhUGIT7texdXR/AgH6epW8mcPPWqkPFoBglK5E4nw2/ynicf7G1VCT1mGmxy89o+L55d/AddKX7hRJoebmhwWrn1TsNCOmjxgm2s+nU7S1SmBn6Djj452wWI+r5PXxk7lvVxKO/UvBcrWTrviclnb6QmLbY4U30Jo3viOLWbzDjSmrQoDx0O4Q8Bw3KY5kfMT3CIUzI37JUKNOcW6WaNf1kRnt+3BNx1g5cPYNE6BTpKpOxEKgWvz8Bu1ZlvG4KQlCdSfOOu4A7ySpFbcAr8ZYc4m1fDklnPGjrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lkq6tBEzDV/YLpVWMcsAZdR15IoNq6y9yJcqLlJaysVRZ7AwcCDQRvBS0YoXIMQ4o6AQQNIaVqdiCIQ/v98F0W7yi1tjJnCeEpM96gCXHJ2xhD21EHBNNWKv6bO6F5TfLLzTtI9rjWFYp+8IrV3xOUkL6p3q7U+H7i3NBlAYfLkUfMKJIvv4EzvWJnHKCSyhWLlcQHFzOxNR83KcUminA1NAhs3L1sbQjXjv6r9mq1U3QSuxqaxnOrMfHWd97SuD2aPCzTTuH5pIFWgeutqiEJxEaHJh98Vj4Ym0VqAPzyRtepnv7tprBQvnUY2tVq+srGxlq5+SBQjNFohFwt508Q==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 06 Jun 2024 07:30:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

06.06.24 10:08, Jan Beulich:
On 04.06.2024 11:34, Sergiy Kibrik wrote:
--- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
+++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
@@ -657,7 +657,7 @@ static int __init cf_check cpufreq_driver_init(void)
case X86_VENDOR_AMD:
          case X86_VENDOR_HYGON:
-            ret = powernow_register_driver();
+            ret = IS_ENABLED(CONFIG_AMD) ? powernow_register_driver() : 
-ENODEV;
              break;
          }

What about the Intel-specific code immediately up from here?
Dealing with that as well may likely permit to reduce ...


you mean to guard a call to hwp_register_driver() the same way as for powernow_register_driver(), and save one stub? ?

  -Sergiy




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.