Re: [RFC PATCH v2] arm: dom0less: add TEE support

[Julien Grall <julien@xxxxxxx>]

Hi Volodymyr,

On 04/06/2024 12:56, Volodymyr Babchuk wrote:
> Hi Julien,
>
> Julien Grall <julien@xxxxxxx> writes:
>
> > Hi Volodymyr,
> >
> > On 31/05/2024 18:49, Volodymyr Babchuk wrote:
> > > Extend TEE mediator interface with two functions :
> > >    - tee_get_type_from_dts() returns TEE type based on input string
> > >    - tee_make_dtb_node() creates a DTB entry for the selected
> > >      TEE mediator
> > > Use those new functions to parse "xen,tee" DTS property for dom0less
> > > guests and enable appropriate TEE mediator.
> [...]
>
> > > +
> > > +    A string property that describes what TEE mediator should be enabled
> > > +    for the domain. Possible property values are:
> > > +
> > > +    - "none" (or missing property value)
> > > +    No TEE will be available in the VM.
> > > +
> > > +    - "OP-TEE"
> > > +    VM will have access to the OP-TEE using classic OP-TEE SMC interface.
> > > +
> > > +    - "FF-A"
> > > +    VM will have access to a TEE using generic FF-A interface.
> > I understand why you chose those name, but it also means we are using
> > different name in XL and Dom0less. I would rather prefer if they are
> > the same.
> Well, my first idea was to introduce additional "const char *dts_name"
> for a TEE mediator description. But it seems redundant. I can rename
> existing mediators so their names will correspond to names used by libxl.
The field name is only used for printing. So I think it would be ok to 
rename the values.
It would also be good to update the comment on top of the definition of 
the field "name" so it is clear the name will be used by dom0less.
Cheers,

--
Julien Grall