Re: [XEN PATCH v3 14/16] ioreq: make arch_vcpu_ioreq_completion() an optional callback

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.06.2024 13:07, Julien Grall wrote:
> On 03/06/2024 12:34, Sergiy Kibrik wrote:
>> @@ -2749,6 +2750,20 @@ static void cf_check vmx_set_reg(struct vcpu *v, 
>> unsigned int reg, uint64_t val)
>>       vmx_vmcs_exit(v);
>>   }
>>   
>> +bool realmode_vcpu_ioreq_completion(enum vio_completion completion)
> 
> No one seems to call this function outside of vmx.c. So can it be 'static'?

Plus it absolutely needs to be cf_check. If it is to stay, which
it looks like it isn't, as per further comments from Julien.

Jan