Re: [PATCH for-4.19? v5 07/10] xen: Make the maximum number of altp2m views configurable for x86

[Julien Grall <julien@xxxxxxx>]

Hi Petr,

On 02/06/2024 21:04, Petr Beneš wrote:
> From: Petr Beneš <w1benny@xxxxxxxxx>
>
> x86: Make the maximum number of altp2m views configurable
>
> This commit introduces the ability to configure the maximum number of altp2m
> views for the domain during its creation. Previously, the limits were hardcoded
> to a maximum of 10. This change allows for greater flexibility in environments
> that require more or fewer altp2m views.
>
> The maximum configurable limit for nr_altp2m on x86 is now set to
> MAX_NR_ALTP2M (which currently holds the MAX_EPTP value - 512). This cap is
> linked to the architectural limit of the EPTP-switching VMFUNC, which supports
> up to 512 entries. Despite there being no inherent need for limiting nr_altp2m
> in scenarios not utilizing VMFUNC, decoupling these components would necessitate
> substantial code changes.
>
> xen_domctl_createdomain::altp2m is extended for a new field `nr`, that will
> configure this limit for a domain. Additionally, previous altp2m.opts value
> has been reduced from uint32_t to uint16_t so that both of these fields occupy
> as little space as possible.
>
> altp2m_get_p2m() function is modified to respect the new nr_altp2m value.
> Accessor functions that operate on EPT arrays are unmodified, since these
> arrays always have fixed size of MAX_EPTP.
>
> A dummy hvm_altp2m_supported() function is introduced for non-HVM builds, so
> that the compilation won't fail for them.
>
> Additional sanitization is introduced in the x86/arch_sanitise_domain_config
> to fix the altp2m.nr value to 10 if it is previously set to 0. This behavior
> is only temporary and immediately removed in the upcoming commit (which will
> disallow creating a domain with enabled altp2m with zero nr_altp2m).
>
> The reason for this temporary workaround is to retain the legacy behavior
> until the feature is fully activated in libxl.
>
> Also, arm/arch_sanitise_domain_config is extended to not allow requesting
> non-zero altp2ms.
>
> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
For the small change in Arm:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx> # arm

Cheers,

--
Julien Grall