[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- From: John Garry <john.g.garry@xxxxxxxxxx>
- Date: Fri, 31 May 2024 10:13:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHHrRtBpQo6HarUUVxEbRkQ1sXtnA7t664mRopKjiWY=; b=SYI7jPGug0dM8HIM8Nsv5t2XcvB2xEGC4IVWQDJ3Rv9eYUFrpbZEwb+N/kHNKWKM/iX5zg1L7s98EeQR/Xb5PtslyA+EmBCYRu4cTeHykW3fuuPz82OnfoV01/IoAxZjHr2zNbAfVbF93bfRZAMX6doEE48/ak4XCtkxtp0opcojdVXRBknFX18iSa8frHKIpQuD9kds4TGhPWFwH5uaf3We+Ich8KzYfE7M7p8/TF2PZ1fLDXbS3d/q6zR6ViRJTO2h4tExHLniSC5Viz9oCiix3DvrdWq9KShBTg4dGgsa2TofkR3wouxrHgUEiMjGydrsrQp5ELtSOUq7aFFrOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DgVZVOUWa3jO0pvA89TlU/2ZjbRkxB+g2bnaXF3d7/iyusPf3K06ieO7a7CbNpeTk3Hntx9W1gfFmwKXXg6LeNz9Hw+4OSTUzeuJE0SxhEE7PWGpJtT/D1n1ooqJ5vCMsEyorb1quGP0w1eX7Y5qrd+K0ez82kAXSb2QVmNVLBHLa0O+I6GHmlbhXQbz57z4v6k0+O90HOZ8X7lEyTiJg0vxhC7klHZDPgu1AjqZFmEcLTwx1MjVKrK6HkLjBGv8F5PkrWVRMqLoXJqwdSd9u4x+LybOUsPrXsqOdcttYXFhLMlBpnFDE/drD2cYtdDGPTGDGt4bsh3rPI5YzkbeIA==
- Cc: Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
- Delivery-date: Fri, 31 May 2024 09:14:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/05/2024 06:04, Christoph Hellwig wrote:
A few drivers optimistically try to support discard, write zeroes and
secure erase and disable the features from the I/O completion handler
if the hardware can't support them. This disable can't be done using
the atomic queue limits API because the I/O completion handlers can't
take sleeping locks or freezer the queue. Keep the existing clearing
of the relevant field to zero, but replace the old blk_queue_max_*
APIs with new disable APIs that force the value to 0.
Signed-off-by: Christoph Hellwig<hch@xxxxxx>
It would be nice to improve this eventually (to use the atomic queue
limits API). Anyway:
Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
|
