[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v12 8/8] xen/README: add compiler and binutils versions for RISC-V64
On Thu, 2024-05-30 at 17:47 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > diff --git a/README b/README > > index c8a108449e..30da5ff9c0 100644 > > --- a/README > > +++ b/README > > @@ -48,6 +48,10 @@ provided by your OS distributor: > > - For ARM 64-bit: > > - GCC 5.1 or later > > - GNU Binutils 2.24 or later > > + - For RISC-V 64-bit: > > + - GCC 12.2 or later > > + - GNU Binutils 2.39 or later > > + Older GCC and GNU Binutils would work, but this is not a > > guarantee. > > This sentence isn't appropriate to live here. > > The commit message saying "this is what we run in CI" is perfectly > good > enough. > > With this dropped, Reviewed-by: Andrew Cooper > <andrew.cooper3@xxxxxxxxxx>. Can fix on commt. I am okay with dropping this sentence, but someone ( unfortunately I don't remember who Jan? Julien? ) requested it, and I think it would be nice to hear their opinion before doing so. ~ Oleksii
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |