Re: [PATCH v12 1/8] xen/riscv: disable unnecessary configs

["Oleksii K." <oleksii.kurochko@xxxxxxxxx>]

On Thu, 2024-05-30 at 17:44 +0100, Andrew Cooper wrote:
> 
> The subject should say "update Kconfig", because you're not (only)
> disabling.
> 
> I'd suggest "xen/riscv: Update Kconfig in preparation for a full Xen
> build".
> 
> On 29/05/2024 8:55 pm, Oleksii Kurochko wrote:
> > Disables unnecessary configs for two cases:
> > 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds
> > (GitLab CI jobs).
> > 2. By using tiny64_defconfig for non-randconfig builds.
> > 
> > Only configs which lead to compilation issues were disabled.
> > 
> > Remove lines related to disablement of configs which aren't
> > affected
> > compilation:
> >  -# CONFIG_SCHED_CREDIT is not set
> >  -# CONFIG_SCHED_RTDS is not set
> >  -# CONFIG_SCHED_NULL is not set
> >  -# CONFIG_SCHED_ARINC653 is not set
> >  -# CONFIG_TRACEBUFFER is not set
> >  -# CONFIG_HYPFS is not set
> >  -# CONFIG_SPECULATIVE_HARDEN_ARRAY is not set
> > 
> > To allow CONFIG_ARGO build happy it was included <asm/p2m.h> to
> > <asm/domain.h>
> > as ARGO requires p2m_type_t ( p2m_ram_rw ) and declaration of
> > check_get_page_from_gfn() from xen/p2m-common.h.
> > 
> > Also, it was included <xen/errno.h> to asm/p2m.h as after the
> > latter was
> > included to <asm/domain.h> the compilation error that EINVAL,
> > EOPNOTSUPP
> > aren't declared started to occur.
> > 
> > CONFIG_XSM=n as it requires an introduction of:
> > * boot_module_find_by_kind()
> > * BOOTMOD_XSM
> > * struct bootmodule
> > * copy_from_paddr()
> > The mentioned things aren't introduced now.
> > 
> > CPU_BOOT_TIME_CPUPOOLS requires an introduction of
> > cpu_physical_id() and
> > acpi_disabled, so it is disabled for now.
> 
> CONFIG_BOOT_TIME_CPUPOOLS
> 
> Also the "depends on DT" isn't good enough as a restriction IMO. 
> It's
> very ARM-dom0less specific.
> 
> > PERF_COUNTERS requires asm/perf.h and asm/perfc-defn.h, so it is
> > also disabled for now, as RISC-V hasn't introduced this headers
> > yet.
> > LIVEPATCH isn't ready for RISC-V too and it can be overriden by
> > randconfig,
> > so to avoid compilation errors for randconfig it is disabled for
> > now.
> 
> PERF_COUNTERS is x86-only, and both LIVEPATCH really should be
> guarded
> by have HAVE_$FOO selected by ARCH.
> 
> However, that's not work to get stuck into now.
> 
> It's quite unreasonable how much stuff doesn't work in simple
> builds...
> 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> I'm happy to fix up the two minor issues on commit.
Thanks. I Would appreciate that.

~ Oleksii