Re: [PATCH v5 6/7] tools: Introduce the "xl dt-overlay attach" command

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 24/05/2024 03:18, Stefano Stabellini wrote:
> From: Henry Wang <xin.wang2@xxxxxxx>
>
> With the XEN_DOMCTL_dt_overlay DOMCTL added, users should be able to
> attach (in the future also detach) devices from the provided DT overlay
> to domains. Support this by introducing a new "xl dt-overlay" command
> and related documentation, i.e. "xl dt-overlay attach. Slightly rework
> the command option parsing logic.
>
> Signed-off-by: Henry Wang <xin.wang2@xxxxxxx>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
>   tools/include/libxl.h               | 15 +++++++++++
>   tools/include/xenctrl.h             |  3 +++
>   tools/libs/ctrl/xc_dt_overlay.c     | 31 +++++++++++++++++++++++
>   tools/libs/light/libxl_dt_overlay.c | 28 +++++++++++++++++++++
>   tools/xl/xl_cmdtable.c              |  4 +--
>   tools/xl/xl_vmcontrol.c             | 39 ++++++++++++++++++++---------
>   6 files changed, 106 insertions(+), 14 deletions(-)
>
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 3b5c18b48b..f2e19ec592 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -643,6 +643,12 @@
>    */
>   #define LIBXL_HAVE_NR_SPIS 1
>   
> +/*
> + * LIBXL_HAVE_OVERLAY_DOMAIN indicates the presence of
> + * libxl_dt_overlay_domain.
> + */
> +#define LIBXL_HAVE_OVERLAY_DOMAIN 1
I think this wants to gain DT_ just before OVERLAY. So from the name it 
is clearer we are talking about the Device-Tree overlay and not 
filesystem (or anything else where overlays are involved).
Cheers,

--
Julien Grall