[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 2/6] x86/intel: move vmce_has_lmce() routine to header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Tue, 21 May 2024 13:00:21 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doe6Hhp9+/08HcLKIHTqxCv1sK8tl+uf27JKsHXvQ14=; b=IujxGpXBWEJnuUgbFyeJjLo50sxTTqUg8MsjYANO3BEctK8vrJwnJ5CmAYNbMqe+xV8DRjz+NanyZtQ3K7O1tKVpsouzpD2NZiqO57NyFg0V9XUDvFNpb9TveaO9VQdIJeeCCYXw+gVSBfo4ubPaK8SXTURb/mw8pcRAR9C08gDAF8cqekBQa+qioV78uOALYOO8VFQ8LXUGBP1DgDetaGdtXxLnFPMHMy6BHcLE+ZtoozRH9AfL9pjUZ78RT7rrQXN2ltIczQpHiYU5L19dS3DoVlm8czZXTFnO9EBDzgIa3nMOnDbx/vXXhA2XyzB2NVMt9Oxj6iYYin0x3/iTag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=calF6uL2o/WyOWr66RKhGSqSkqtHPpWvMJDqK42gsqGgw2QCYLNAJ8K+2b+nCSNKUZk01GOGRVRXCcSzgwN8JZwUSeTG8lNXnukPZQRKLeok/QFk+xNSSglpp6jCBUwgOrakWwqmLcueuSDF6pQ065orhEmgpPceS6gjaQ5iIP70wWDRiuCS7Xa708qICKQ5x4BoLPfg3ICjDRsk+6uJUUuC4rvDMjBoSqFMxMl5WJ81URng8yHW7iX/SHNZmJhrkHLYBJ6tTVLgLm9Y1eA0I5w7MjTzS/gospyiOltVrNe1lWJf8IN67kmTdWW0TcLR8adOnwNVQQFU6P/q4d+hYA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 May 2024 10:00:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
21.05.24 09:05, Jan Beulich:
This is because MCG_LMCE_P is defined in arch/x86/cpu/mcheck/x86_mca.h
-- so either MCG_LMCE_P (+ a bunch of MCG_* declarations) has to be
moved to common header to be accessible, or local x86_mca.h got to be
included from common arch/x86/include/asm/mce.h.
As for the MCG_* declarations movement I didn't think there's a good
enough reason to do it; as for the inclusion of x86_mca.h it didn't look
nice at all.
I'm afraid I don't follow the latter: Why's including x86_mca.h any worse
than what you do right now?
To include x86_mca.h from asm/mce.h something like this line would be
needed:
#include "../../cpu/mcheck/x86_mca.h"
I've found only two include-s of such kind, so I presume they're not common.
Besides xen/sched.h includes asm/mce.h before declaration of struct
vcpu, so body of vmce_has_lmce(const struct vcpu *v) can't really be
compiled in asm/mce.h
-Sergiy
|
